1591002 - remove remaining use of <xul:text> from calendar (<text> removed in bug 1590903)

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Magnus Melin [:mkmelin]]

Bug 1590903 (now on inbound) is removing xul:text. Of the code we use, only some things left in calendar/.

https://searchfox.org/comm-central/search?q=%3Ctext&case=true&regexp=true&path=calendar

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1590903_rm_text.patch

Changed the ones in the <deck> to <html:div>, and the year to label (since minimonth attribute year is mapped to setting value=)

Comment 2

[Jorg K (CEST = GMT+2)]

The M-C bug has landed now.

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9103880 [details] [diff] [review]
bug1590903_rm_text.patch

Review of attachment 9103880 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look fine to me.  When I tried to test it, the Calendar UI was not loading at all for me when building from here: https://hg.mozilla.org/comm-central/rev/b0318a86aa5d682c36a59d40324a5517d9bb461a
There's a network error in the console that looks suspicious: https://paste.mozilla.org/z5vSwkJ8

Comment 4

[Paul Morris [:pmorris]]

I've now got a working build (not sure what was going wrong there...), tested the patch and everything is fine as expected.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ba97cb20859d
remove remaining use of <xul:text> from calendar (<text> removed in bug 1590903). r=pmorris