Closed Bug 1591002 Opened 5 months ago Closed 5 months ago

remove remaining use of <xul:text> from calendar (<text> removed in bug 1590903)

Categories

(Calendar :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(1 file)

Bug 1590903 (now on inbound) is removing xul:text. Of the code we use, only some things left in calendar/.

https://searchfox.org/comm-central/search?q=%3Ctext&case=true&regexp=true&path=calendar

Blocks: 1590903

Changed the ones in the <deck> to <html:div>, and the year to label (since minimonth attribute year is mapped to setting value=)

Attachment #9103880 - Flags: review?(paul)

The M-C bug has landed now.

Comment on attachment 9103880 [details] [diff] [review]
bug1590903_rm_text.patch

Review of attachment 9103880 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look fine to me.  When I tried to test it, the Calendar UI was not loading at all for me when building from here: https://hg.mozilla.org/comm-central/rev/b0318a86aa5d682c36a59d40324a5517d9bb461a
There's a network error in the console that looks suspicious: https://paste.mozilla.org/z5vSwkJ8
Attachment #9103880 - Flags: review?(paul) → review+

I've now got a working build (not sure what was going wrong there...), tested the patch and everything is fine as expected.

Target Milestone: --- → 72

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ba97cb20859d
remove remaining use of <xul:text> from calendar (<text> removed in bug 1590903). r=pmorris

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.