1591025 - Show the pause reason in the Pause Overlay when remote debugging mobile Firefox

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[Julian Descottes [:jdescottes]]

Followup to Bug 1590932.

The current implementation of the pause overlay is relying on a client side properties file to show the "pause" reason (whyPaused. strings from https://searchfox.org/mozilla-central/source/devtools/client/locales/en-US/debugger.properties#743)

This file is not available on mobile builds of Firefox and crashes the debugger. Since we need to uplift a fix we will provide a temporary solution in Bug 1590932 that doesn't show the pause reason in mobile builds.

However we should find a solution to provide the same feature to users debugging mobile Firefox. Either move the strings to a shared file, or let the client pass the string to the highlighter?

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report Julian!
Honza

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I guess we can use the highlighter properties file we already have: https://searchfox.org/mozilla-central/source/devtools/shared/locales/en-US/highlighters.properties

I'll give this a try

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1591025 - [devtools] Rename shared debugger.properties into security-prompt.properties. r=jdescottes.

The next patch of this queue will add a shared debugger.properties file for
actual debugger related strings.
The file we're renaming doesn't have much to do with the debugger, so we
can rename it to something more specific.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1591025 - [devtools] Display PausedDebuggerOverlay images in remote debugged Fenix. r=jdescottes.

Depends on D132223

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1591025 - [devtools] Move whyPaused.* string to a ftl file in devtools/shared. r=bomsy!,jdescottes!

Since those strings can be consumed by the PausedDebuggerOverlay, on the server,
we need to put them in devtools/shared.
As this will create some work for the l10n team, we migrate them to Fluent so we're
feeding 2 birds with 1 scone.
The <LocalizationProvider> is added directly in <WhyPaused> (and not in <App>,
as it's messing up with the React context (See Bug 1743155).
Some snapshots are updated. It's unfortunate that we don't see the translated
strings there anymore, but we can't have nice things in Jest.

Comment 6

[Phabricator Automation]

Comment on attachment 9252666 [details]
Bug 1591025 - [devtools] Move whyPaused.* string to a ftl file in devtools/shared. r=bomsy!,jdescottes!

Revision D132260 was moved to bug 1743347. Setting attachment 9252666 [details] to obsolete.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48c568e6d4d4
[devtools] Display PausedDebuggerOverlay images in remote debugged Fenix. r=jdescottes.

Comment 8

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing mochitest failures on browser_metrics_debugger.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c6b7e343048bd01cfd8f5df563795debcd558fdf

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=48c568e6d4d4497f7886264efb3fe93346f4341f&selectedTaskRun=MHXJVi03SdWDvm5ABGftPQ.0

Link to failure log : https://treeherder.mozilla.org/logviewer?job_id=359928129&repo=autoland&lineNumber=2865

Failure message: TEST-UNEXPECTED-FAIL | devtools/client/framework/test/metrics/browser_metrics_debugger.js | Duplicated module load detected. List of duplicated modules

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90369a230cb4
[devtools] Display PausedDebuggerOverlay images in remote debugged Fenix. r=jdescottes.

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/90369a230cb4