1591076 - Popups show wrong value

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

This issue can be observed on retriggered data points.

STR

1. Go to a plot which has some retriggered data points and zoom onto them (example).
2. Choose a commit with retriggered data points (e8905725eb46e, for example).
3. Hover over each of the retriggered data points.

Expected results:
From top to bottom on the chosen commit, the popup should show the 68.22, 62.00, 59.41 and 58.48 values.

What we actually get:
Popup always shows the 62.00 value, which corresponds to the first data point, no matter what data point you hover onto.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/5657

Comment 2

[Sarah Clements [:sclements]]

This fix will use the performance datum primary key/id to find tooltip data (was previously using push id) and will add it to the selected query param but is backwards compatible so this patch won't break old links that show a tooltip.

Comment 3

[Sarah Clements [:sclements]]

Merged: https://github.com/mozilla/treeherder/commit/44632dc582abf514cce9ec4d30aab30777023d24
Should be deployed to production on Thursday.