1591100 - Form submission with empty query string submits to wrong URL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE:

1. Load http://example.com
2. Open web console.
3. Evaluate var form = document.createElement("form"); document.body.appendChild(form); form.submit()

EXPECTED RESULTS: Loaded URL is "http://example.com/?"; see bug 1586740 comment 7 for the reasoning.

ACTUAL RESULTS: Loaded URL is "http://example.com".

This is happening because at https://searchfox.org/mozilla-central/rev/088e2cf29c59d733d57af43903eb0267dbf72e2a/dom/html/HTMLFormSubmission.cpp#290 we use SetQuery, which treats empty string as "remove the query".

Valentin, is there any way to make this work apart from prepending "?" to the query on the caller side, which will force a copy of the entire query string, as far as I can tell? The spec has a distinction between "set query to empty string" and "set query to null" which doesn't map well to what our URI classes do...

Comment 1

[Valentin Gosu [:valentin] (he/him)]

The API doesn't handle this case automatically, but if calling SetQuery with an empty string is the only issue with this, I assume we can change the callsite to say something like:
rv = NS_MutateURI(aURI).SetQuery(mQueryString.IsEmpty() ? NS_LITERAL_CSTRING("?") : mQueryString).Finalize(aOutURI);

It's less risky than trying to change the behaviour of SetQuery, and less intricate than adding a new method deals with this case specifically.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1591100. Fix the form submission URL for the empty-query case.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8f97dccb432
Fix the form submission URL for the empty-query case. r=smaug

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22239 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b8f97dccb432

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot