Move the PIP player based on its screen position when resized
Categories
(Toolkit :: Video/Audio Controls, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | verified |
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
Attachments
(1 file)
When a PIP video is resized the player window will resize with it in bug 1535437. When the dimensions of the player window change though, the video might not be positioned where the user intended anymore.
For example, a 4:3 video in the original bottom right anchor resizing to 16:9 will now have space below the video, instead of being snug to the bottom of the window.
Alternatively, the user could have moved the video up the right side of the screen and expect it to be anchored on the right side, but changing to a vertical video will now show space to the right of the video.
The top/left case works already since without moving the window after resize the top left corner of the video remains in place.
A solution could be to maintain the position of the right edge of the video if the video is on the right side of the screen, and do the same for the bottom edge when the video is on the bottom half of the screen.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7cc2f6d9640 Maintain PiP player position when source video is resized r=mconley
|
||
Comment 3•5 years ago
|
||
Backed out 3 changesets (bug 1535437, bug 1591253) for causing browser_resizeVideo.js to permafail
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-6%2Cm%28bc6%29&revision=f7cc2f6d9640820f5278bbc7787ccae542e06e69
backout: https://hg.mozilla.org/integration/autoland/rev/96b4cb315770c2037cb2cee9c7ffd76ef252ed2b
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8222591127e9 Maintain PiP player position when source video is resized r=mconley
|
||
Comment 5•4 years ago
|
||
Backed out for perma fails on browser_resizeVideo.js.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1535437#c10
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/968273f4e59b Maintain PiP player position when source video is resized r=mconley
|
||
Comment 7•4 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
||
Comment 8•4 years ago
|
||
Marking this as verified-fixed on FX73 on Windows 10, MacOS 10.13 and Ubuntu 18.04.
The PiP window now maintains its position and properly resizes when the video size is changed.
Description
•