1591268 - Stub installers for 70.0 request full installer using partner-firefox-release-rc-<partner>...

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, defect)

Description

[Patrick O'Shaughnessey]

If you download and run the installer at https://download.mozilla.org/?product=partner-firefox-release-firefoxreality-ffreality-htc-001-stub&os=win&lang=en-US, it gets stuck at the progress screen and does not complete.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

The full installer urls in partner.ini

[DownloadURL]
X86="https://download.mozilla.org/?product=partner-firefox-release-rc-firefoxreality-ffreality-htc-001-latest&os=win&lang=en-US"
AMD64="https://download.mozilla.org/?product=partner-firefox-release-rc-firefoxreality-ffreality-htc-001-latest&os=win64&lang=en-US"

are getting a 404 response from bouncer. Investigating ...

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

The issue is the -rc- part of partner-firefox-release-rc-firefoxreality..., it should be partner-firefox-release-firefoxreality....

This will be affecting all the partners we do stub installers for, which is firefoxreality-ffreality-htc-001, firefoxreality-ffreality-htc-up-001, firefoxreality-ffreality-steam-001, firefoxreality-ffreality-steam-up-001, ironsource-isltd-001, ironsource-isltd-002, ironsource-isltd-003, ironsource-isltd-004, mailru-mailru, mailru-okru, softonic-softonic-004, softonic-softonic-005, softonic-softonic-006, softonic-softonic-008, softonic-softonic-009, softonic-softonic-010, softonic-softonic-011, softonic-softonic-012, yandex-yandex-ru

I'll add some extra aliases in bouncer to fix up the problem for now, and then fix up the stub repacking code.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

This showed up now because it's the first X.0 release we've done with stubs, which were added for 69.0.1.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

The aliases have been added to bouncer, except for partner-firefox-release-rc-firefoxreality-ffreality-steam-up-001-{stub,latest}. @mkaply, we don't have publish_to_releases=true in repack.cfg for that, by design or accident ?

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: GitHub Pull Request - repack script

Comment 6

[Patrick O'Shaughnessey]

NOTE: the "os=win64" version of the installer works! i.e.:
https://download.mozilla.org/?product=partner-firefox-release-firefoxreality-ffreality-htc-001-stub&os=win64&lang=en-US

I don't think we'll be pushing anyone to the 32-bit version, so maybe this can be closed?

Comment 7

[Mike Kaply [:mkaply]]

Accident. I thought I had fixed.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

To clarify what's going on here

• the stub installer is built as part of the win32 build, and the partner repacking code assumes wanting the stub means wanting multiple platforms, so we get win32 and win64 full installers
• as a convenience the stub is available with either os=win (meaning win32) or os=win64, it's the same file regardless
• the url that the stub installer is using for the full installer was broken until a workaround at comment #4
• the github PR will fix this for future releases (from 71.0)

We could avoid confusion by only having a full installer, so I'm curious why we're using the stub. Something something better install experience ?

Comment 9

[Mike Kaply [:mkaply]]

Yeah, they wanted the stub for the better experience.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to Mike Kaply [:mkaply] from comment #7)

Accident. I thought I had fixed.

Looks like the fix just missed the start of 70.0 build2, which we ended up shipping. All looks well for the next release, and I hear one is coming along sometime soon, so I will let that resolve the unpublished files for ffreality-steam-up-001. Let me know if you need that to work asap though.

Thanks for spotting this problem Patrick.