Closed Bug 1591306 Opened 5 years ago Closed 5 years ago

Preferences pane scrolls before loading is complete

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird71 fixed, thunderbird72 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 72.0
Tracking Flags:
Tracking Status
thunderbird71 --- fixed
thunderbird72 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

1591306-preferences-scroll-order.diff
2.96 KB, patch
mkmelin
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review

Scrolling is happening before loading is complete, so sometimes scrolling goes to the wrong place. This has broken the tests on Windows since bug 1590206 landed.

Attachment #9104127 - Flags: review?(mkmelin+mozilla)
Attachment #9104127 - Flags: approval-comm-beta?

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/13785840481c
Scroll preferences pane after loading is complete; r=bustage-fix

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
Attachment #9104127 - Flags: review?(mkmelin+mozilla) → review+
Comment on attachment 9104127 [details] [diff] [review]
1591306-preferences-scroll-order.diff

Interesting. Is anything broken in the beta or just in the tests?
Attachment #9104127 - Flags: approval-comm-beta? → approval-comm-beta+

Technically yes it's broken, anything that loads the preferences window a certain point could be affected. In practice I don't think any code we ship is affected by this.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: