Closed Bug 1591346 Opened 6 months ago Closed 5 months ago

Remove EGL_ANGLE_experimental_present_path usage with WebRender

Categories

(Core :: Graphics: WebRender, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

EGL_ANGLE_experimental_present_path was enabled for fast rendering to SwapChain by ANGLE. But current gecko does not request ANGLE to render to SwapChain for WebRender. Then we do not need to use EGL_ANGLE_experimental_present_path anymore.

But when EGL_ANGLE_experimental_present_path is removed, rendering result of frame buffer is y flipped with ANGLE compared to other OpenGL implementation.

Assignee: nobody → sotaro.ikeda.g
Blocks: 1591004

The following is fist check-in of EGL_ANGLE_experimental_present_path implementation.
https://github.com/google/angle/commit/2a63b3f8600bb9f90ff2870a0e1a23d251d45239

(In reply to Sotaro Ikeda [:sotaro] from comment #0)

Instead, we could use EGL_ANGLE_surface_orientation for Y flip. It is already used by chromium.

Hmm, it seems that we could not use EGL_ANGLE_surface_orientation for non SwapChain EGLSurface :(

Attachment #9104161 - Attachment is obsolete: true

It seems that gecko could do similar thing like comment 4.

gecko already has similar function. NativeLayer::SurfaceIsFlipped()
https://searchfox.org/mozilla-central/source/gfx/layers/NativeLayer.h#81

Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9277be3613ca
Remove EGL_ANGLE_experimental_present_path usage with WebRender r=gw
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.