1591355 - Remove support for XUL <editor> element

Status: NEW

(Toolkit :: UI Widgets, task, P2)

Description

[Tim Nguyen :ntim]

Looks unused:
https://searchfox.org/mozilla-central/search?q=%3Ceditor&case=false&regexp=false&path=
https://searchfox.org/mozilla-central/search?q=create.*Element.*%5C%28.*%22editor&regexp=true&path=

Platform code:
https://searchfox.org/mozilla-central/search?q=nsGkAtoms%3A%3Aeditor&case=false&regexp=false&path=
https://searchfox.org/mozilla-central/source/toolkit/content/widgets/editor.js
https://searchfox.org/mozilla-central/search?q=%3Ceditor&case=false&regexp=false&path=test
https://searchfox.org/mozilla-central/rev/2a355e56c490768be676689de18629485c9d699b/xpcom/ds/StaticAtoms.py#398

For comm-central, I think using <iframe> instead should work. Looks like this will need porting the MozEditor CE to be ported, and the platform code to be kept or the MozEditor CE could potentially extend browser/iframe. This doesn't look trivial to port, so I guess it could be held off for now.

Comment 1

[Magnus Melin [:mkmelin]]

Anything in particular that made you change your mind about <iframe> being a direct alternative?

Comment 2

[Tim Nguyen :ntim]

(In reply to Magnus Melin [:mkmelin] from comment #1)

Anything in particular that made you change your mind about <iframe> being a direct alternative?

Editor is bound to a custom element: https://searchfox.org/mozilla-central/source/toolkit/content/widgets/editor.js
Iframe isn't. Also, there's some differences in terms of focus behaviour on the platform side.

I think you could try making editor a XUL <iframe is="editor-frame"> or <browser is="editor-browser"> and then port the CE to comm-central with the CE extending XULFrameElement.