1591362 - Removing Cookies and Site Data clears more disk cache than it should

Status: VERIFIED FIXED

(Toolkit :: Data Sanitization, defect, P1)

Description

[Qwerty]

STR:

1. Create clean profile on nightly
2. Open mozilla.org or twitter.com or reddit.com
3. Open https://commons.wikimedia.org/
4. On wikimedia open "Random file" link many times to collect cache (e.g. 20 mb), or open few large images like https://upload.wikimedia.org/wikipedia/commons/0/05/Citizen_of_Castelo_de_Monsanto.jpg
5. Open about:preferences#privacy and delete cookies for domain(s) from step 2.

AR:
About half of the cache or more purges. Sometimes you can see in about:cache that you lose https://upload.wikimedia.org/wikipedia/commons/0/05/Citizen_of_Castelo_de_Monsanto.jpg after clearing cookies for unrelated domains (like twitter/reddit). If you have 1 GB cache, you lose almost all of it.

ER:
Cache loses only related data.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1591362 - Fix incorrect origin comparison in CacheFileContextEvictor::EvictEntries(). r=baku!,mayhemer!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cae493b7ba52
Fix incorrect origin comparison in CacheFileContextEvictor::EvictEntries(). r=baku,mayhemer,michal

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/cae493b7ba52

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 9120914 [details]
Bug 1591362 - Fix incorrect origin comparison in CacheFileContextEvictor::EvictEntries(). r=baku!,mayhemer!

Beta/Release Uplift Approval Request

• User impact if declined: Clearing cache for a specific origin through various means, under certain conditions, clears all cache except that belonging to the origin. Fun.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner that flips a quite obviously wrong condition. This code should only be run when clearing the cache.
• String changes made/needed: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9120914 [details]
Bug 1591362 - Fix incorrect origin comparison in CacheFileContextEvictor::EvictEntries(). r=baku!,mayhemer!

Fixes a logical error to avoid incorrectly evicting cache items. Approved for 73.0b9.

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3e32cd5df849

Comment 8

[Alin Ilea, Desktop QA]

Reproduced the initial issue using an old Beta build.
Verified - Fixed in latest Nightly build 74.0a1 (Build id: 20200122215748) and Beta 73.0b9 (Build id: 20200123022532) using Windows 10.

Comment 9

[Rob N]

No. This is NOT fixed in FF-75. Regression testing will fail.

Replictate:
.Visit Site. (facebook in my case)
.Have issues.
.Click Padlock on the main bar
.Click "Clear Cookies and Site Data.."
Only the current site is shown.
.Confirm by clicking "REMOVE"

Bam. All site data and cache and cookies gone.

Expected result.
Have to re login in to that specific site. NOT EVERY SITE

comment:
It's small but when two factor auth is on various sites, it gets real tiresome.

Comment 10

[Rob N]

(In reply to Rob N from comment #9)

No. This is NOT fixed in FF-75. Regression testing will fail.

Replictate:
.Visit Site. (facebook in my case)
.Have issues.
.Click Padlock on the main bar
.Click "Clear Cookies and Site Data.."
Only the current site is shown.
.Confirm by clicking "REMOVE"

Bam. All site data and cache and cookies gone.

Expected result:
Have to re login in to that specific site.
NOT EVERY SITE.

comment:
It's small but when two factor auth is on various sites, it gets real tiresome.

Comment 11

[Rob N]

[Tracking Requested - why for this release]:

Comment 12

[Rob N]

Quick update: It seems that "delete cookies and history and site data" option was checked.
It may have been my mis-click as i am constantly (as an intense youtube video consumer) having to clear the 1gb cache.
via: (: Options > Privacy and Security > Clear Data. ULTRA CAREFUL to UNcheck 'Cookies and Site Data', leaving only 'Cached Web Content' Checked. Click 'Clear' (we really need a quick button to clear the cache and not touch the cookies on the menu bar!!)

I'll repeat in a new sesstion after computer restart (windows 7 ult) and report my results back.

Comment 13

[Johann Hofmann [:johannh]]

Ah, yes, we have a bug for this, let me dig it up...

Comment 14

[Johann Hofmann [:johannh]]

Ah, it's bug 1463114. See also this comment:

[...] I would highly recommend to use an add-on like https://addons.mozilla.org/en-US/firefox/addon/clearcache/ instead.