1591386 - Perma spidermonkey - test262/intl402/DateTimeFormat/prototype/formatToParts/related-year.js - when Gecko 72 merges to Beta on 2019-12-02

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Dorel Luca [:dluca]]

[Tracking Requested - why for this release]:

Central As beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=5e92ffcc2d859f91dd5f4049877ca3b2d8ff51fc&selectedJob=272943805

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272943805&repo=try&lineNumber=43978

TEST-KNOWN-FAIL | test262/intl402/DateTimeFormat/prototype/formatToParts/fractionalSecondDigits.js | (args: "") | (SKIP) [0.0 s]
[task 2019-10-25T11:41:41.025Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/format/bound-to-datetimeformat-instance.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.033Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/format/proleptic-gregorian-calendar.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.033Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/format/format-function-builtin.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.051Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/date-is-infinity-throws.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.062Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/this-has-not-internal-throws.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.071Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/formatToParts.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.101Z] ## test262/intl402/DateTimeFormat/prototype/formatToParts/related-year.js: rc = 3, run time = 0.152527
[task 2019-10-25T11:41:41.102Z] uncaught exception: Test262Error: Expected SameValue(«false», «true») to be true
[task 2019-10-25T11:41:41.102Z] Stack:
[task 2019-10-25T11:41:41.102Z]   $ERROR@/builds/worker/workspace/build/src/js/src/tests/test262/shell.js:406:9
[task 2019-10-25T11:41:41.102Z]   assert.sameValue@/builds/worker/workspace/build/src/js/src/tests/test262/shell.js:51:9
[task 2019-10-25T11:41:41.102Z]   @/builds/worker/workspace/build/src/js/src/tests/test262/intl402/DateTimeFormat/prototype/formatToParts/related-year.js:20:8
[task 2019-10-25T11:41:41.102Z] TEST-UNEXPECTED-FAIL | test262/intl402/DateTimeFormat/prototype/formatToParts/related-year.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.107Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/this-is-not-object-throws.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.114Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/time-clip-to-integer.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.115Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/date-is-nan-throws.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.130Z] TEST-PASS | test262/intl402/DateTimeFormat/supportedLocalesOf/prop-desc.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.147Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/return-abrupt-tonumber-date.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.155Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/time-clip-near-time-boundaries.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.155Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/date-constructor-not-called.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.155Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/name.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.155Z] TEST-PASS | test262/intl402/DateTimeFormat/supportedLocalesOf/length.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.184Z] TEST-PASS | test262/intl402/DateTimeFormat/supportedLocalesOf/name.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.193Z] TEST-PASS | test262/intl402/DateTimeFormat/supportedLocalesOf/taint-Object-prototype.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.201Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/main.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.202Z] TEST-PASS | test262/intl402/DateTimeFormat/supportedLocalesOf/builtin.js | (args: "") [0.1 s]
[task 2019-10-25T11:41:41.217Z] ## test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js: rc = 3, run time = 0.198282
[task 2019-10-25T11:41:41.218Z] uncaught exception: Test262Error: Expected SameValue(«false», «true») to be true
[task 2019-10-25T11:41:41.218Z] Stack:
[task 2019-10-25T11:41:41.219Z]   $ERROR@/builds/worker/workspace/build/src/js/src/tests/test262/shell.js:406:9
[task 2019-10-25T11:41:41.219Z]   assert.sameValue@/builds/worker/workspace/build/src/js/src/tests/test262/shell.js:51:9
[task 2019-10-25T11:41:41.219Z]   @/builds/worker/workspace/build/src/js/src/tests/test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js:53:8
[task 2019-10-25T11:41:41.219Z] TEST-UNEXPECTED-FAIL | test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js | (args: "") [0.2 s]
[task 2019-10-25T11:41:41.224Z] TEST-PASS | test262/intl402/DateTimeFormat/supportedLocalesOf/basic.js | (args: "") [0.2 s]

Jason: Can you please take a look at this bug?

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1591386 - Mark the one test262 test of DateTimeFormat relatedYear functionality as nightly-only, til we enable the field in beta/release. r=jorendorff

Comment 2

[Jeff Walden [:Waldo]]

I can't seem to find any existing incantations to skip a test262 test in beta/release only, so this is a little bit of a guess at the incantation. It does appear to work with jstests.py run from the shell. https://treeherder.mozilla.org/#/jobs?repo=try&revision=23af5da38fc424bc8630002d08cad6125eafd43b should indicate whether the incantation works in the browser...probably. If getBuildConfiguration isn't usable in skip-if conditions in the browser harness, we'll have to try something else, but I'm not sure what the something else would be, exactly.

Comment 3

[Jeff Walden [:Waldo]]

Bah, getBuildConfiguration apparently isn't available in jstests in the browser. :-( Retrying with an imprecise conditional:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0cb69ace9aa25d76ba6b6247f5054227a4ff9d98

Comment 4

[André Bargull [:anba]]

Simple skip-if(release_or_beta) should work, release_or_beta is exported as a global variable in the xul-tester. Examples: https://searchfox.org/mozilla-central/search?q=skip-if(release_or_beta)&case=true&regexp=false&path=

Comment 5

[Natalia Csoregi [:nataliaCs]]

After importing the patch, the following spider-monkey bustage occurred on test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js:
central as beta: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=273070223&revision=f240cd4eb2e712483535f23a8d9175931fd388f1&searchStr=spidermonkey

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273070223&repo=try&lineNumber=42841

[task 2019-10-26T11:14:36.475Z] TEST-KNOWN-FAIL | test262/intl402/DateTimeFormat/prototype/formatRangeToParts/builtin.js | (args: "") | (SKIP) [0.0 s]
[task 2019-10-26T11:14:36.500Z] TEST-PASS | test262/intl402/DateTimeFormat/prototype/formatToParts/time-clip-to-integer.js | (args: "") [0.1 s]
[task 2019-10-26T11:14:36.510Z] ## test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js: rc = 3, run time = 0.206172
[task 2019-10-26T11:14:36.510Z] uncaught exception: Test262Error: Expected SameValue(«false», «true») to be true
[task 2019-10-26T11:14:36.510Z] Stack:
[task 2019-10-26T11:14:36.510Z] $ERROR@/builds/worker/workspace/build/src/js/src/tests/test262/shell.js:406:9
[task 2019-10-26T11:14:36.510Z] assert.sameValue@/builds/worker/workspace/build/src/js/src/tests/test262/shell.js:51:9
[task 2019-10-26T11:14:36.510Z] @/builds/worker/workspace/build/src/js/src/tests/test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js:53:8
[task 2019-10-26T11:14:36.510Z] TEST-UNEXPECTED-FAIL | test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js | (args: "") [0.2 s]

Also, jit test failures https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273071813&repo=try&lineNumber=1426

[task 2019-10-26T11:27:27.133Z] 11:27:27 INFO - REFTEST INFO | Dumping JSON representation of sandbox
[task 2019-10-26T11:27:27.136Z] 11:27:27 INFO - REFTEST INFO | {"isDebugBuild":false,"xulRuntime":{"widgetToolkit":"gtk","OS":"Linux","XPCOMABI":"x86_64-gcc3"},"smallScreen":false,"d2d":false,"dwrite":false,"gpuProcess":false,"azureCairo":false,"azureSkia":true,"skiaContent":true,"azureSkiaGL":false,"contentSameGfxBackendAsCanvas":true,"remoteCanvas":false,"layersGPUAccelerated":false,"d3d11":false,"d3d9":false,"layersOpenGL":false,"webrender":false,"layersOMTC":true,"advancedLayers":false,"layerChecksEnabled":true,"retainedDisplayList":true,"usesOverlayScrollbars":false,"Android":false,"cocoaWidget":false,"gtkWidget":true,"qtWidget":false,"winWidget":false,"is64Bit":true,"geckoview":false,"transparentScrollbars":true,"AddressSanitizer":true,"webrtc":true,"xbl":false,"retainedDisplayLists":true,"compareRetainedDisplayLists":false,"skiaPdf":false,"release_or_beta":true,"http":{"userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0","appName":"Mozilla","appVersion":"5.0","platform":"X11","oscpu":"Linux x86_64","misc":"rv:72.0"},"haveTestPlugin":true,"windowsDefaultTheme":false,"nativeThemePref":true,"gpuProcessForceEnabled":false,"prefs":{},"browserIsRemote":true,"asyncPan":true,"usesRepeatResampling":false,"verify":false,"fission":false,"serviceWorkerE10s":false}
[task 2019-10-26T11:27:32.351Z] 11:27:32 ERROR - REFTEST ERROR | EXCEPTION: ReferenceError: getBuildConfiguration is not defined
[task 2019-10-26T11:33:42.355Z] 11:33:42 ERROR - REFTEST ERROR | None | application timed out after 370 seconds with no output
[task 2019-10-26T11:33:42.356Z] 11:33:42 ERROR - REFTEST ERROR | Force-terminating active process(es).
[task 2019-10-26T11:33:42.357Z] 11:33:42 INFO - REFTEST TEST-INFO | started process screentopng
[task 2019-10-26T11:33:42.698Z] 11:33:42 INFO - REFTEST TEST-INFO | screentopng: exit 0
[task 2019-10-26T11:33:42.698Z] 11:33:42 INFO - REFTEST INFO | Can't trigger Breakpad, just killing process
[task 2019-10-26T11:33:42.775Z] 11:33:42 ERROR - TEST-UNEXPECTED-FAIL | None | application terminated with exit code -15

:Waldo, could we track these issues on this same bug since they appeared after importing the attached patch, or should we file separate bugs?
Thank you.

Comment 6

[Jeff Walden [:Waldo]]

The jit-test failure is me doing the test wrong. The updated patch does the test right, and that should disappear.

The first problem, in test262/intl402/DateTimeFormat/prototype/formatToParts/pattern-on-calendar.js, is unrelated to the bug summary, but -- now that I scroll through it a little -- it is related to comment 0, just further scrolled down. Aesthetically, possibly two bugs is better. Practically, it probably doesn't matter.

The first problem appears to be a recent new test, for a normative spec change. https://github.com/tc39/ecma402/pull/349 The v8 patching for the corresponding spec change seems to implicate relatedYear as integral to what happens here, so probably we ought skip this too. But it's the end of the day, and a weekend at that, and I shouldn't be spending this much time thinking about this now. :-) Tomorrow!

Comment 7

[Intermittent Failures Robot]

2 failures in 4182 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform breakdown:

• windows2012-aarch64: 1
• windows2012-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1591386&startday=2019-10-21&endday=2019-10-27&tree=all

Comment 8

[Intermittent Failures Robot]

32 failures in 865 pushes (0.037 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 32

Platform breakdown:

• linux64: 20
• windows2012-64: 4
• windows2012-aarch64: 2
• linux32: 2
• windows2012-32: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1591386&startday=2019-10-29&endday=2019-10-29&tree=all

Comment 9

[Cosmin Sabou [:CosminS]]

Jeff, any updates on this? It's still busting spidermonkey builds on beta sims: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=78a856dfefb438d526359a87432db94ddd9f85fe&searchStr=spidermonkey&selectedJob=273648601

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f85a31690fff
Mark the one test262 test of DateTimeFormat relatedYear functionality as nightly-only, til we enable the field in beta/release.  r=jorendorff

Comment 11

[Jeff Walden [:Waldo]]

Attachment: Bug 1591386 - Mark one other test262 test of DateTimeFormat functionality as nightly-only, til we enable the relatedYear field in beta/release. r=jorendorff

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f85a31690fff

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ceeb77f79442
Mark one other test262 test of DateTimeFormat functionality as nightly-only, til we enable the relatedYear field in beta/release.  r=jorendorff

Comment 15

[Cristina Coroiu [:ccoroiu]]

Backed out changeset ceeb77f79442 (bug 1591386) for jsreftests at jsreftest.html?test=non262/Date/15.9.5.7.js

Backout: https://hg.mozilla.org/integration/autoland/rev/cc9db0fdd4c61fe7bf5efbdace841d54dbdbea92

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ceeb77f79442a9710da29162281e3403955a9a22

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274256907&repo=autoland&lineNumber=2444

task 2019-11-03T01:31:45.724Z] 01:31:45 INFO - REFTEST TEST-PASS | file:///Z:/task_1572740053/build/tests/jsreftest/tests/jsreftest.html?test=non262/Date/15.9.5.7.js | d = new Date(1572744705700); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) item 12
[task 2019-11-03T01:31:45.724Z] 01:31:45 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1572740053/build/tests/jsreftest/tests/jsreftest.html?test=non262/Date/15.9.5.7.js | d = new Date(1572773505700); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) wrong value item 13
[task 2019-11-03T01:31:45.725Z] 01:31:45 INFO - REFTEST TEST-PASS | file:///Z:/task_1572740053/build/tests/jsreftest/tests/jsreftest.html?test=non262/Date/15.9.5.7.js | d = new Date(1104537600000); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) item 14
[task 2019-11-03T01:31:45.725Z] 01:31:45 INFO - REFTEST TEST-PASS | file:///Z:/task_1572740053/build/tests/jsreftest/tests/jsreftest.html?test=non262/Date/15.9.5.7.js | d = new Date(1104537599000); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) item 15
[task 2019-11-03T01:31:45.726Z] 01:31:45 INFO - REFTEST TEST-PASS | file:///Z:/task_1572740053/build/tests/jsreftest/tests/jsreftest.html?test=non262/Date/15.9.5.7.js | d = new Date(1104566400000); d == new Date(d.toDateString() + " " + d.toLocaleTimeString()) item 16
[task 2019-11-03T01:31:45.726Z] 01:31:45 INFO - REFTEST INFO | Saved log: START file:///Z:/task_1572740053/build/tests/jsreftest/tests/jsreftest.html?test=non262/Date/15.9.5.7.js
[task 2019-11-03T01:31:45.726Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-11-03T01:31:45.727Z] 01:31:45 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-11-03T01:31:45.727Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] AfterOnLoadScripts belatedly entering WaitForTestEnd
[task 2019-11-03T01:31:45.728Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
[task 2019-11-03T01:31:45.728Z] 01:31:45 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-11-03T01:31:45.729Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
[task 2019-11-03T01:31:45.729Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: dispatching MozReftestInvalidate
[task 2019-11-03T01:31:45.729Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
[task 2019-11-03T01:31:45.730Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_SPELL_CHECKS
[task 2019-11-03T01:31:45.730Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_APZ_FLUSH
[task 2019-11-03T01:31:45.730Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: APZ flush not required
[task 2019-11-03T01:31:45.730Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FINISH
[task 2019-11-03T01:31:45.731Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: Doing sync flush to compositor
[task 2019-11-03T01:31:45.731Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] MakeProgress: Completed
[task 2019-11-03T01:31:45.731Z] 01:31:45 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-11-03T01:31:45.731Z] 01:31:45 INFO - REFTEST INFO | Saved log: RecordResult fired

Comment 16

[Cristian Brindusan [:cbrindusan]]

Fyi, after the above backout, for today's beta-sims I've backout the other changeset and we've got sm bustages on related-year.js:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=usercancel%2Ctestfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=07db119dc837d6ee9855fb6568d65b857da97dea&selectedJob=274276392

Comment 17

[Andreea Pavel [:apavel]]

Waldo: fyi, with both patches imported in the beta sims, the spidermonkey bustages no longer appear:

Early Beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=7615639a6ca7cad0078a854e1331d7a58444619a

Late beta: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9af07027e58ee15082650968cfca0901bbe7c2eb

Basically, both patches from here fix the issue they were made for, however the last one causes permafails on integration.

Comment 18

[Intermittent Failures Robot]

54 failures in 4314 pushes (0.013 failures/push) were associated with this bug in the last 7 days.

This is the #32 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• try: 54

Platform breakdown:

• linux64: 35
• windows2012-64: 6
• windows2012-aarch64: 3
• linux32: 4
• windows2012-32: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1591386&startday=2019-10-28&endday=2019-11-03&tree=all

Comment 19

[André Bargull [:anba]]

The issue in comment #15 can safely be ignored. It was caused by the DST change in the US, so it won't reproduce until the next DST change.

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b916ab4900e
Mark one other test262 test of DateTimeFormat functionality as nightly-only, til we enable the relatedYear field in beta/release.  r=jorendorff

Comment 21

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8b916ab4900e

Comment 22

[Alexandru Michis [:malexandru]]

Verified fixed as of latest central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception&revision=9be0afd3ae2983d15a75b46ef0c7510e65f4fc4b&searchStr=spidermonkey&group_state=expanded