1591424 - [wpt-sync] Sync PR 19855 - css-flexbox: narrow special case for deprecated flex box

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19855 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19855
Details from upstream follow.

Scott Violet <[e-mail]> wrote:

css-flexbox: narrow special case for deprecated flex box

https://chromium-review.googlesource.com/c/chromium/src/+/1845506
modified LayoutBox::SizesLogicalWidthToFitContent() to return true
for webkit-blox/webkit-inline-box. This is problematic as the display
type does not necessarily correlate to the LayoutObject that is used.
The right fix is to look at the display type and the LayoutObject
used.

BUG=1014001
TEST=external/wpt/compat/webkit-box-fieldset.html

Change-Id: I80cc6d166e02c1e2ec6c2c0c58bcf770793ca41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874250
Commit-Queue: Scott Violet \<[e-mail]>
Reviewed-by: Christian Biesinger \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#709205}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac3fb8b130ada4d64095903501f39ef95d6dfae8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

PASS: 1

Chrome

PASS: 1

Safari

FAIL: 1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1591424 [wpt PR 19855] - css-flexbox: narrow special case for deprecated flex box, a=testonly

Automatic update from web-platform-tests
css-flexbox: narrow special case for deprecated flex box

https://chromium-review.googlesource.com/c/chromium/src/+/1845506
modified LayoutBox::SizesLogicalWidthToFitContent() to return true
for webkit-blox/webkit-inline-box. This is problematic as the display
type does not necessarily correlate to the LayoutObject that is used.
The right fix is to look at the display type and the LayoutObject
used.

BUG=1014001
TEST=external/wpt/compat/webkit-box-fieldset.html

Change-Id: I80cc6d166e02c1e2ec6c2c0c58bcf770793ca41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874250
Commit-Queue: Scott Violet <[e-mail]>
Reviewed-by: Christian Biesinger <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#709205}

--

wpt-commits: bee8fe07402f7f919688a16ac13def147b79a6eb
wpt-pr: 19855

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8406ded1a78
[wpt PR 19855] - css-flexbox: narrow special case for deprecated flex box, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e8406ded1a78