Closed Bug 1591424 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 19855 - css-flexbox: narrow special case for deprecated flex box

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 19855 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19855
Details from upstream follow.

Scott Violet <sky@chromium.org> wrote:

css-flexbox: narrow special case for deprecated flex box

https://chromium-review.googlesource.com/c/chromium/src/+/1845506
modified LayoutBox::SizesLogicalWidthToFitContent() to return true
for webkit-blox/webkit-inline-box. This is problematic as the display
type does not necessarily correlate to the LayoutObject that is used.
The right fix is to look at the display type and the LayoutObject
used.

BUG=1014001
TEST=external/wpt/compat/webkit-box-fieldset.html

Change-Id: I80cc6d166e02c1e2ec6c2c0c58bcf770793ca41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874250
Commit-Queue: Scott Violet \<sky@chromium.org>
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709205}

Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

PASS: 1

Chrome

PASS: 1

Safari

FAIL: 1

Automatic update from web-platform-tests
css-flexbox: narrow special case for deprecated flex box

https://chromium-review.googlesource.com/c/chromium/src/+/1845506
modified LayoutBox::SizesLogicalWidthToFitContent() to return true
for webkit-blox/webkit-inline-box. This is problematic as the display
type does not necessarily correlate to the LayoutObject that is used.
The right fix is to look at the display type and the LayoutObject
used.

BUG=1014001
TEST=external/wpt/compat/webkit-box-fieldset.html

Change-Id: I80cc6d166e02c1e2ec6c2c0c58bcf770793ca41e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874250
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709205}

--

wpt-commits: bee8fe07402f7f919688a16ac13def147b79a6eb
wpt-pr: 19855

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8406ded1a78
[wpt PR 19855] - css-flexbox: narrow special case for deprecated flex box, a=testonly
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.