Closed Bug 1591432 Opened 3 years ago Closed 3 years ago

Crash in [@ TFont::FindColourBitmapForGlyph]

Categories

(Core :: Graphics: Text, defect, P3)

70 Branch
Desktop
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox-esr68 --- wontfix
firefox70 --- wontfix
firefox71 --- fixed
firefox72 --- fixed

People

(Reporter: marcia, Assigned: lsalzman)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

This bug is for crash report bp-83d2a8b5-9bea-469e-b8e4-a93ca0191025.

Seen while reviewing macOS release crash stats: https://bit.ly/2WdtLzZ. This regression is 10.9 only and seems to have started in 71.0b2. There are no URLs and no comments.

Here is the changelog for that beta: https://mzl.la/340XnU4

Top 10 frames of crashing thread:

0 CoreText TFont::FindColourBitmapForGlyph const 
1 CoreText TFont::CreatePathForGlyph const 
2 CoreText CTFontCreatePathForGlyph 
3 XUL SkScalerContext_Mac::generateMetrics gfx/skia/skia/src/ports/SkFontHost_mac.cpp:1260
4 XUL SkScalerContext::getMetrics gfx/skia/skia/src/core/SkScalerContext.cpp:189
5 libmozglue.dylib arena_t::MallocSmall memory/build/mozjemalloc.cpp:2827
6 libmozglue.dylib arena_t::DallocSmall memory/build/mozjemalloc.cpp:3242
7 libmozglue.dylib free memory/build/malloc_decls.h:41
8 XUL SkStrike::lookupByPackedGlyphID gfx/skia/skia/src/core/SkStrike.cpp
9 XUL SkTextInterceptsIter::next gfx/skia/skia/src/core/SkTextBlob.cpp:955

Component: Graphics → Graphics: Text

ni? Lee in case something stands out from the stack traces.

Flags: needinfo?(lsalzman)
Priority: -- → P3

It seems that the fix the we're crashing on in Skia was introduced by them upstream in 2011, before 10.9 was ever released. Whether or not the check is still necessary seems an open question, but for now, let's just avoid it when a color font is being used, which should at least work around this bug.

Flags: needinfo?(lsalzman)
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3cae791d670
avoid creating paths for color fonts on macOS. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Comment on attachment 9107047 [details]
Bug 1591432 - avoid creating paths for color fonts on macOS. r?jrmuizel

Beta/Release Uplift Approval Request

  • User impact if declined: Crashes on macOS 10.9 when displaying text.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Disables an upstream bugfix that was introduced in 2011 (prior to 10.9) and which may no longer be necessary. The upstream bugfix is actually causing us to executing the code that is crashing, so disabling this should stop the crashing. However, we don't have enough crashes in nightly to ascertain whether this fixes it, so I would like to uplift this to beta and see if this fixes the issue there. This should otherwise be fairly harmless, so if it does not solve the crash, we can always back it out later.
  • String changes made/needed:
Attachment #9107047 - Flags: approval-mozilla-beta?

Comment on attachment 9107047 [details]
Bug 1591432 - avoid creating paths for color fonts on macOS. r?jrmuizel

Crash fix for macos 10.9, if we are still crashing in beta 11, let's backout this patch. Uplift approved for 71 beta 9, thanks.

Attachment #9107047 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

this crash is repapering in 72 after the volume seems to have decreased in 71 where the patch got uplifted to.
should we get a new bug on file for the remaining issue or reopen this bug?

Flags: needinfo?(lsalzman)

(In reply to [:philipp] from comment #10)

this crash is repapering in 72 after the volume seems to have decreased in 71 where the patch got uplifted to.
should we get a new bug on file for the remaining issue or reopen this bug?

File a new bug, please.

Flags: needinfo?(lsalzman)
Blocks: 1609184
You need to log in before you can comment on or make changes to this bug.