Closed Bug 1591441 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 19868 - [css-lists] Add test for list-style-type:<string> with Ahem font

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 19868 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19868
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-lists] Add test for list-style-type:<string> with Ahem font

In the other reftests the width of the marker text is not known, so the
references have to rely on some tricks with the ::before pseudo-element.

This patch adds a test that uses the Ahem font, so that the width of the
characters is known. Then the result can be checked with a simpler
reference file.

Note it fails in LayoutNG due to the lack of scrollbar (bug 1012294),
but it passes in legacy.

Bug: 687946
Change-Id: I7fd0856e93d4e489af65b5c767ec81c109804c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879067
Commit-Queue: Oriol Brufau \<obrufau@igalia.com>
Reviewed-by: Manuel Rego \<rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709405}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Automatic update from web-platform-tests
[css-lists] Add test for list-style-type:<string> with Ahem font

In the other reftests the width of the marker text is not known, so the
references have to rely on some tricks with the ::before pseudo-element.

This patch adds a test that uses the Ahem font, so that the width of the
characters is known. Then the result can be checked with a simpler
reference file.

Note it fails in LayoutNG due to the lack of scrollbar (bug 1012294),
but it passes in legacy.

Bug: 687946
Change-Id: I7fd0856e93d4e489af65b5c767ec81c109804c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879067
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709405}

--

wpt-commits: 52aeca2db20bd3304407bf1a1fca4e5a827db243
wpt-pr: 19868

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77dde5467624
[wpt PR 19868] - [css-lists] Add test for list-style-type:<string> with Ahem font, a=testonly
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.