1591515 - Avoid delazification in js::FunctionToString

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

If js::FunctionToString we current delazify in [1], but it isn't necessary. Instead this whole method should be cleaned up in terms of JSFunction::baseScript(). Another minor detail is that [2] can be simplified since derived-class-constructors are no longer marked as builtin thanks to [3].

[1] https://searchfox.org/mozilla-central/rev/7536d7f480a7f18c941a590a2d4c5119d9f52770/js/src/vm/JSFunction.cpp#836
[2] https://searchfox.org/mozilla-central/rev/7536d7f480a7f18c941a590a2d4c5119d9f52770/js/src/vm/JSFunction.cpp#857
[3] https://searchfox.org/mozilla-central/rev/7536d7f480a7f18c941a590a2d4c5119d9f52770/js/src/vm/Interpreter.cpp#311

Comment 1

[Ted Campbell [:tcampbell]]

Note, one wrinkle is FunctionToStringCache, but I think changing it to store a BaseScript* is fine. The cache is wiped at any GC and is never traced so the fact that BaseScript is not really a complete type is fine.

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1591515 - Avoid delazification in js::FunctionToString

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/integration/autoland/rev/78b04bb8a18beb1fdaca10f1e113e6567a6051bb

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/78b04bb8a18b