1591597 - Extensions are not shown after checking for updates

Status: UNCONFIRMED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Artem S. Tashkinov]

Attachment: clip.mkv

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Steps to reproduce:

1. Set the extensions tab active item to "Available updates"
2. Close Firefox
3. Open the extensions tab
4. Check for updates

New found updates will not be shown.

They should be shown immediately.

5. Click "View available updates"

Again nothing will happen.

See the attached video clip.

Comment 1

[Artem S. Tashkinov]

It's been like that since the introduction the brand new and shiny extensions manager.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Jim Mathies [:jimm]]

(In reply to Artem S. Tashkinov from comment #0)

Created attachment 9104358 [details]
clip.mkv

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Steps to reproduce:

1. Set the extensions tab active item to "Available updates"

Can you clarify what interface this is? FWIW I can't view your video.

Comment 4

[Artem S. Tashkinov]

This is a standard mkv file with standard H.264 video which could be played with any video player which supports the mentioned container and video codec.

I've uploaded it on YouTube as well: https://youtu.be/zigPeoBb5mk

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Mark Striemer [:mstriemer]]

Took a look at this, something like this works but this code probably doesn't belong in the page header.

diff --git a/toolkit/mozapps/extensions/content/aboutaddons.js b/toolkit/mozapps/extensions/content/aboutaddons.js
--- a/toolkit/mozapps/extensions/content/aboutaddons.js
+++ b/toolkit/mozapps/extensions/content/aboutaddons.js
@@ -1412,9 +1412,18 @@ class AddonPageOptions extends HTMLEleme

   async onClick(e) {
     switch (e.target.getAttribute("action")) {
-      case "check-for-updates":
+      case "check-for-updates": {
         await this.checkForUpdates();
+        let view = this.getTelemetryViewName();
+        if (view == "updates") {
+          // Refresh any updates views since they might've changed.
+          let list = document.querySelector("addon-list");
+          if (list) {
+            list.render();
+          }
+        }
         break;
+      }
       case "view-recent-updates":
         loadViewFn("updates/recent", e);
         break;

Maybe we should be sending an onPropertyChanged event for the add-on when we find an update.

Comment 7

[Artem S. Tashkinov]

Firefox 75 beta 7: still affected.

Comment 8

[Artem S. Tashkinov]

Firefox 82: still affected.