1591653 - [wpt-sync] Sync PR 19919 - [fetch] Opt-in to single-page test feature

Status: RESOLVED FIXED

(Core :: DOM: Networking, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19919 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19919
Details from upstream follow.

Mike Pennisi <[e-mail]> wrote:

[fetch] Opt-in to single-page test feature

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update the tests which previously opted in implicitly to use the new
API.

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=64bc404d3a41bc60fd510333d15c135e3b711654

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 9 tests and 22 subtests

Firefox

OK : 8
PASS : 7
FAIL : 2
TIMEOUT: 1

Chrome

OK : 8
PASS : 8
FAIL : 1
TIMEOUT: 1

Safari

OK : 8
PASS : 8
FAIL : 1
TIMEOUT: 1

Firefox-only failures

/fetch/images/canvas-remote-read-remote-image-redirect.html
Load a no-cors image from a same-origin URL that redirects to a cross-origin URL that redirects to the initial origin: Firefox: FAIL

Other existing tests that now have a worse result

/fetch/corb/style-html-correctly-labeled.sub.html
style-html-correctly-labeled: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/fetch/corb/style-css-with-json-parser-breaker.sub.html
style-css-with-json-parser-breaker: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/fetch/corb/style-css-mislabeled-as-html.sub.html
style-css-mislabeled-as-html: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/fetch/corb/style-css-mislabeled-as-html-nosniff.sub.html
style-css-mislabeled-as-html-nosniff: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/fetch/corb/script-resource-with-nonsniffable-types.tentative.sub.html: Firefox: OK->TIMEOUT, Chrome: OK->TIMEOUT, Safari: OK->TIMEOUT
CORB does not block 'application/blah': Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
CORB does not block 'application/javascript': Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
CORB does not block 'text/html': Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

Other new tests that's don't pass

/fetch/corb/script-resource-with-nonsniffable-types.tentative.sub.html
script-resource-with-nonsniffable-types: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Gecko CI Results

Ran 9 tests and 9 subtests
OK : 9
PASS : 7
FAIL : 2

Existing tests that now have a worse result

/fetch/corb/script-resource-with-nonsniffable-types.tentative.sub.html
script-resource-with-nonsniffable-types: FAIL

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Bug 1591653 [wpt PR 19919] - [fetch] Opt-in to single-page test feature, a=testonly

Automatic update from web-platform-tests
[fetch] Refactor tests (#19919)

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update some tests which previously opted in implicitly to use the new
API. Update others to instead declare a single subtest (so that they are
no longer single-page tests).

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

wpt-commits: ef85c0ffb5ef120a3165d0f1763e6fa864eb274f
wpt-pr: 19919

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Attachment: Bug 1591653 [wpt PR 19919] - Update wpt metadata, a=testonly

wpt-pr: 19919
wpt-type: metadata

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bb2afd5cf83
[wpt PR 19919] - [fetch] Opt-in to single-page test feature, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7d850e34991b
[wpt PR 19919] - Update wpt metadata, a=testonly

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2bb2afd5cf83
https://hg.mozilla.org/mozilla-central/rev/7d850e34991b