Closed Bug 1591656 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19921 - [css-shapes] Opt-in to single-page test feature

Categories

(Core :: Layout: Floats, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 19921 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19921
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:

[css-shapes] Opt-in to single-page test feature

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update the tests which previously opted in implicitly to use the new
API.

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Component: CSS Parsing and Computation → Layout: Floats

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 18 tests and 14 subtests

Firefox

OK : 14
PASS: 18

Chrome

OK : 14
PASS: 18

Safari

OK : 14
PASS: 17
FAIL: 1

Gecko CI Results

Ran 18 tests and 13 subtests
OK : 14
PASS : 17

Automatic update from web-platform-tests
[css-shapes] Refactor tests (#19921)

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update some tests which previously opted in implicitly to use the new
API. Update others to instead declare a single subtest (so that they are
no longer single-page tests).

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

wpt-commits: e6c03912b75fe8b8aefeacc8814ae6e8a0c78679
wpt-pr: 19921

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee8bfb6f8f89
[wpt PR 19921] - [css-shapes] Refactor tests, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.