Closed Bug 1591659 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19924 - [compat] Opt-in to single-page test feature

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 19924 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19924
Details from upstream follow.

Mike Pennisi <mike@mikepennisi.com> wrote:

[compat] Opt-in to single-page test feature

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update the tests which previously opted in implicitly to use the new
API.

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

Component: web-platform-tests → Layout
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 2 subtests

Firefox

OK : 1
PASS : 1

Chrome

OK : 1
PASS : 1

Safari

OK : 1
PASS : 1

Existing tests that now have a worse result

/compat/webkit-box-removing-triggering-anonymous-merge.html
webkit-box-removing-triggering-anonymous-merge: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

Gecko CI Results

Ran 1 tests and 1 subtests
OK : 1
PASS : 1

Automatic update from web-platform-tests
[compat] Refactor test (#19924)

testharness.js was recently extended with an API to explicitly opt-in to
the "single page test" feature [1]. As per WPT RFC 28 [2], tests which
do not use this API and which do not declare any subtests will soon be
reported as a harness error.

Update the tests which previously opted in implicitly to instead declare
a single subtest (so that it is no longer a single-page test).

[1] https://github.com/web-platform-tests/wpt/pull/19449
[2] https://github.com/web-platform-tests/rfcs/blob/master/rfcs/single_test.md

wpt-commits: 1092d667b008dbd598fee995ec890c669f9ffe52
wpt-pr: 19924

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54593aeee272
[wpt PR 19924] - [compat] Refactor test, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: