1591718 - Cannot enable Push Notifications on twitter.com

Status: VERIFIED FIXED

(Core :: DOM: Push Subscriptions, defect, P2)

Description

[Alice0775 White]

Reproducible:
Nightly72.0a1(20191026094546)
Firefox71.0b4
This problem seems to appear on EARLY_BETA_OR_EARLIER build(early Beta and Nightly).

Steps to reproduce:

1. login to twitter.com
2. Click "Notifications" label in the left sidebar
3. Click Gear icon in the top of middle pane
4. Click "Push notofications" in Preferences pane
5. Click [Turn on] button or toggle "Push notofications" widget

Actual results:
twitter said as follows.

Unsupported browser
It looks like your browser doesn’t support push notifications.

No allow notification-popup appears at AddressBar. (see https://support.mozilla.org/en-US/kb/push-notifications-firefox?as=u&utm_source=inproduct)

Expected results:
An allow notification-popup should appear at AddressBar. (see https://support.mozilla.org/en-US/kb/push-notifications-firefox?as=u&utm_source=inproduct)

Comment 1

[Alice0775 White]

FWIW,
Fixed range in 70beta cycle:
https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=1a169f1e113dbb537eb5490c8561e1671b5b94ca&tochange=b9b3e10bc8fcd8c3bff7bc50a73ff950bd5e60f1

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4338bf79beb22e84559426cfd1421d6e6acda03f&tochange=6bad31e6ca426e6094d109ff3bf311f325829913

Regressed by: 6bad31e6ca426e6094d109ff3bf311f325829913 Johann Hofmann — Bug 1540088 - Require user interaction for push notification permission prompts in Nightly. r=Ehsan

How I can enable push notification?

Comment 3

[Johann Hofmann [:johannh]]

Thanks for filing this! I was under the impression that this had worked before. They have user interaction when requesting but they seem to lose it at some point. So, this is definitely a case that should work under the new model, but that it doesn't seems like more of a bug on Twitter's side.

Peter, do you think you can reach out to Twitter and check if they can fix this on their side?

How I can enable push notification?

You will see a small icon wiggle on the left of the URL bar when you try to enable notifications on Twitter. Just click on it and accept the notification request. Then reload the page and things should work fine. Otherwise just use the permissions tab in Page Info.

Comment 4

[Alice0775 White]

(In reply to Johann Hofmann [:johannh] from comment #3)

How I can enable push notification?

You will see a small icon wiggle on the left of the URL bar when you try to enable notifications on Twitter. Just click on it and accept the notification request. Then reload the page and things should work fine. Otherwise just use the permissions tab in Page Info.

Thanks.
It works after set "Send Notification" to "allow" from the permissions tab in Page Info & reload.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

I'll try contacting folks at twitter as well.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this broken only in nightly/early beta?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:edenchuang, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Eden Chuang[:edenchuang]]

Set it as p2. According to Johann's comment, might need Twitter's support.
I will take some time to look deeply later.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

We are in RC week and this is a P2, setting 71 as fix-optional in case we have a dot release in December and a safe fix could be uplifted as a ride along.

Comment 10

[Anne (:annevk)]

Edgar, now that bug 1129227 is fixed and stuck, how much work would it be to use the same logic for the notification permission dialog? Johann and I expect that it would fix this issue as we'd no longer rely on not losing the user interaction bit across a series of callbacks.

Perhaps we should track implementing that separately, but would be good to at least have some kind of estimate depending on how severe we consider this issue to be.

Comment 11

[Edgar Chen [:edgar]]

(In reply to Anne (:annevk) from comment #10)

Edgar, now that bug 1129227 is fixed and stuck, how much work would it be to use the same logic for the notification permission dialog?

I expect that replacing the UserActivation::IsHandlingUserInput() call in ContentPermissionRequestBase with new API in the document should just work.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Seems like this bug is a bigger issue now with bug 1593644 enabling the Push permission prompts by default for Release 72?

Comment 13

[Johann Hofmann [:johannh]]

This will be fully fixed with bug 1606839 to the point where we might just dupe it...

Comment 14

[Johann Hofmann [:johannh]]

This should have been fixed by bug 1606839, but it would be nice to get independent verification on this.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Hi Alice, can you please confirm that this is working for you now? Thanks!

Comment 16

[Alice0775 White]

Yes, this is fixed. I cannot reproduce the issue on Nightly74.0a1(20200116120508) Windows10.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

This should be fixed in 73.0b7 as well.

Comment 18

[ddssantana89]

I'm facing this same issue on firefox 74.0.1 (windows 10). Twitter is reporting that my browser does not support push notifications.