Fix AddonManagerWebAPI::IsAPIEnabled in Fission out-of-process iframes
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: zombie, Assigned: zombie)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This comment and logic is not correct with Fission:
https://searchfox.org/mozilla-central/rev/67ecac7/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp#119-121
An iframe with a cross-origin parent will have an out-of-process content parent, which a docShell will know nothing about, so we need to ask the BrowsingContext.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Seems good, both locally with --verify and on Try.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93f340370eb015ab4c966ca1d091196d59dcb540
Pushed by tjovanovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/51c14691f8e7 Fix AddonManagerWebAPI::IsAPIEnabled in out-of-process iframes r=mixedpuppy
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
|
||
Comment 5•5 years ago
|
||
Hello,
Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!
|
|
Assignee | |
Comment 6•5 years ago
|
||
Not needed, covered by automation tests, thanks.
|
||
Comment 7•5 years ago
|
||
Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.
This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:
0ee3c76a-bc79-4eb2-8d12-05dc0b68e732
Description
•