1591736 - Fix AddonManagerWebAPI::IsAPIEnabled in Fission out-of-process iframes

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Tomislav Jovanovic :zombie]

This comment and logic is not correct with Fission:
https://searchfox.org/mozilla-central/rev/67ecac7/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp#119-121

An iframe with a cross-origin parent will have an out-of-process content parent, which a docShell will know nothing about, so we need to ask the BrowsingContext.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Bug 1591736 - Fix AddonManagerWebAPI::IsAPIEnabled in out-of-process iframes

Comment 2

[Tomislav Jovanovic :zombie]

Seems good, both locally with --verify and on Try.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=93f340370eb015ab4c966ca1d091196d59dcb540

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51c14691f8e7
Fix AddonManagerWebAPI::IsAPIEnabled in out-of-process iframes r=mixedpuppy

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/51c14691f8e7

Comment 5

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 6

[Tomislav Jovanovic :zombie]

Not needed, covered by automation tests, thanks.

Comment 7

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732