Closed Bug 1591736 Opened 22 days ago Closed 19 days ago

Fix AddonManagerWebAPI::IsAPIEnabled in Fission out-of-process iframes

Categories

(Toolkit :: Add-ons Manager, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Fission Milestone M4
Tracking Status
firefox72 --- fixed

People

(Reporter: Tomislav, Assigned: Tomislav)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This comment and logic is not correct with Fission:
https://searchfox.org/mozilla-central/rev/67ecac7/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp#119-121

An iframe with a cross-origin parent will have an out-of-process content parent, which a docShell will know nothing about, so we need to ask the BrowsingContext.

Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51c14691f8e7
Fix AddonManagerWebAPI::IsAPIEnabled in out-of-process iframes r=mixedpuppy
Status: NEW → RESOLVED
Closed: 19 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Flags: needinfo?(tomica)

Not needed, covered by automation tests, thanks.

Flags: needinfo?(tomica) → qe-verify-

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
You need to log in before you can comment on or make changes to this bug.