Closed Bug 1591749 Opened 1 year ago Closed 1 year ago

Enhance SeaMonkey's certificate / net error code

Categories

(SeaMonkey :: General, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

RESOLVED FIXED
seamonkey2.69
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 3 obsolete files)

This patch ports parts of the following:

  • Bug 369814 - don't open jar: content unless served from a safe mime type
  • Bug 380932 - land netError page for malware URIs
  • Bug 427293 - add a pref to unhide the buttons on the bad-cert error page by default for advanced users
  • Bug 451250 - When navigating session history, use an error page instead of the POSTDATA prompt
  • Bug 529697 - (CSP 1.1) Implement form-action directive [3/4]
  • Bug 624883 - Treat view-source as an unrecognised scheme if not top-level
  • Bug 625760 - Make "Remote XUL unsupported" error page localizable
  • Bug 682294 - Add an error page for file access denied
  • Bug 989197 - Show alternate UI in cert error pages when a captive portal is active
  • Bug 107491 - Follow up checkin, one more place where nssFailure needs to be renamed
  • Bug 1122642 - Have an error page for H2 INADEQUATE_SECURITY
  • Bug 1220481 - New responsive designs for error pages
  • Bug 1240594 - Merge about:neterror and about:certerror UI code
  • Bug 1267514 - Fix about:neterror generic fallback text when there is no available title/description for the error
  • Bug 1274729 - corrupted content string management
  • Bug 1394460 - Update illustration and copy for error: invalid URL
  • Bug 1394462 - Update dnsNotFound error copy and illustration
Blocks: 1581176
Depends on: 1581314, 1581177
Attached patch Enhance code (obsolete) — Splinter Review

Potentially still more code to go in (excluding the captive portal parts) but want feedback on what is here so far.

Attachment #9104463 - Flags: feedback?(frgrahl)
Attached patch Enhance code v1.1 (obsolete) — Splinter Review

Special cased dnsNotFound and malformedURI errors as they don't contain id="errorCode"

Attachment #9104463 - Attachment is obsolete: true
Attachment #9104463 - Flags: feedback?(frgrahl)
Attachment #9107217 - Flags: feedback?(frgrahl)
Comment on attachment 9107217 [details] [diff] [review]
Enhance code v1.1

Looks much better than the old page but there are still a lot of cases where the Add Exception button is shown:
- Enter about:neterror or about:certerror in the urlbar. 
- Try an unknown protocol: goolpher://sksk
- Network Timeout http://10.1.1.10/
and so on. 

I am seeing 
>Timestamp: 11/10/2019, 12:39:57 AM
>Error: TypeError: desc is null
>Source File: chrome://communicator/content/certError.js
>Line: 96
or 
>Timestamp: 11/10/2019, 12:38:00 AM
>Error: TypeError: codeResult is null
>Source File: chrome://communicator/content/certError.js
>Line: 96
so this might be used to sort out the "bad" ones"?

f+
Attachment #9107217 - Flags: feedback?(frgrahl) → feedback+
Attached patch 99999.patch (obsolete) — Splinter Review

Adding the checks in the patch fixes the net:error issues. Avoids the exceptions and lets the code run till it disables the button in

// For neterrors do not show the What Should I Do and Technical Details
// sections.
if (document.documentURI.startsWith("about:neterror")) {

Just entering about:certerror still shows it but this should be the only case left and not very relevant.

This patch now also ports parts of:

  • Bug 1394460 - Update illustration and copy for error: invalid URL
  • Bug 1394451 - Add an illustration to net errors
Attachment #9107217 - Attachment is obsolete: true
Attachment #9107733 - Attachment is obsolete: true
Attachment #9108149 - Flags: review?(frgrahl)
Attachment #9108149 - Flags: approval-comm-release?
Attachment #9108149 - Flags: approval-comm-esr60?
Comment on attachment 9108149 [details] [diff] [review]
Enhance code v1.3

lgtm 
Tested with 2.53 and 2.57
Attachment #9108149 - Flags: review?(frgrahl)
Attachment #9108149 - Flags: review+
Attachment #9108149 - Flags: approval-comm-release?
Attachment #9108149 - Flags: approval-comm-release+
Attachment #9108149 - Flags: approval-comm-esr60?
Attachment #9108149 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/54cb02ce13e7
Enhance SeaMonkey's certificate / net error code. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.