Closed Bug 1591781 Opened 5 months ago Closed 5 months ago

Port bug 1587135: On Windows 7 Classic, make the tabs-toolbar styling simpler

Categories

(Thunderbird :: Theme, task)

All
Windows 7
task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 72.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files)

No description provided.

We hadn't the box-shadow before but for the readability it's better we follow FX.

There is also some conversion from #messengerWindow[tabsintitlebar] to :root[tabsintitlebar] to make the code a bit faster (depending some comment from an other FX bug which converted this on other places).

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9104495 - Flags: review?(jorgk)
Attached image Classic-comparison.png

For easier review a comparison of before (top) and after (bottom) the patch.

Comment on attachment 9104495 [details] [diff] [review]
1591781-classic-gradient.patch

Looks like a semi-straight port of https://hg.mozilla.org/mozilla-central/rev/7eed9c4167e5. We have some quirks, like the `border-bottom: 1px solid transparent;` stuff which is also documented in a comment above.

`@media (-moz-windows-classic)` is for Win7 only or can I test this on Win10? In the screenshot I don't see much difference, however the chat and calendar icons have moved more to the right. That's a desired side effect?

Classic is Windows 7 only. That's why I added a screenshot with the comparison.

We have some differences to FX because we have two toolboxes for the tabs and the main toolbox which makes some tweaks needed to look like it's one toolbox.

Comment on attachment 9104495 [details] [diff] [review]
1591781-classic-gradient.patch

OK, rs=jorgk.
Attachment #9104495 - Flags: review?(jorgk) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/37638cf21b56
Port bug 1587135: Replace the position and :after hack on top of the classic title bar with a simpler gradient. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 72.0
You need to log in before you can comment on or make changes to this bug.