1591781 - Port bug 1587135: On Windows 7 Classic, make the tabs-toolbar styling simpler

Status: RESOLVED FIXED

(Thunderbird :: Theme, task)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1591781-classic-gradient.patch

We hadn't the box-shadow before but for the readability it's better we follow FX.

There is also some conversion from #messengerWindow[tabsintitlebar] to :root[tabsintitlebar] to make the code a bit faster (depending some comment from an other FX bug which converted this on other places).

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Classic-comparison.png

For easier review a comparison of before (top) and after (bottom) the patch.

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9104495 [details] [diff] [review]
1591781-classic-gradient.patch

Looks like a semi-straight port of https://hg.mozilla.org/mozilla-central/rev/7eed9c4167e5. We have some quirks, like the `border-bottom: 1px solid transparent;` stuff which is also documented in a comment above.

`@media (-moz-windows-classic)` is for Win7 only or can I test this on Win10? In the screenshot I don't see much difference, however the chat and calendar icons have moved more to the right. That's a desired side effect?

Comment 4

[Richard Marti (:Paenglab)]

Classic is Windows 7 only. That's why I added a screenshot with the comparison.

We have some differences to FX because we have two toolboxes for the tabs and the main toolbox which makes some tweaks needed to look like it's one toolbox.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9104495 [details] [diff] [review]
1591781-classic-gradient.patch

OK, rs=jorgk.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/37638cf21b56
Port bug 1587135: Replace the position and :after hack on top of the classic title bar with a simpler gradient. r=jorgk