Closed Bug 1591797 Opened 6 years ago Closed 6 years ago

Firefox 70.0 dark mode does not stay dark

Categories

(Firefox :: Theme, defect)

70 Branch
x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: info, Unassigned)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Running GalliumOS 3.0 xfce 4.12, used dark theme on Firefox for the last several versions and all was good. Updated to Firefox 70.0 and dark theme does not work properly. Initially toggled dark theme and all was dark, but as soon as a new window/tab was opened everything above the view window turned light again. This occurred simultaneously on all Firefox windows open at a given time.

Actual results:

Tried restarting Firefox and computer multiple times with same results. Video below. Switched between Light/Default/Dark with same issue occurring each time.

Expected results:

Dark theme stays dark

Component: Untriaged → Theme
OS: Unspecified → Linux
Hardware: Unspecified → x86_64

I've had a very similar issue caused by an add-on once... does it occur for you on a fresh profile?

I found one extension that causes this issue. https://addons.mozilla.org/en-US/firefox/addon/native-dark/
It's a dynamic theme that has not been updated to https://blog.mozilla.org/addons/2019/07/25/upcoming-deprecations-in-firefox-70/

The behavior is same on all release channels - selecting a theme from customization mode works - until a new window is opened at which point things change to white.

The real problem with this is that it's not apparent that it's caused by the extension. It looks like a theme issue and dynamic themes are not listed in themes section of customization view or addons manager.

Would it be possible to disable loading of dynamic themes that have their last update some time before the deprecation of those few css properties was announced?

(In reply to jastekken from comment #2)

I found one extension that causes this issue. https://addons.mozilla.org/en-US/firefox/addon/native-dark/
It's a dynamic theme that has not been updated to https://blog.mozilla.org/addons/2019/07/25/upcoming-deprecations-in-firefox-70/

The behavior is same on all release channels - selecting a theme from customization mode works - until a new window is opened at which point things change to white.

The real problem with this is that it's not apparent that it's caused by the extension. It looks like a theme issue and dynamic themes are not listed in themes section of customization view or addons manager.

Would it be possible to disable loading of dynamic themes that have their last update some time before the deprecation of those few css properties was announced?

Spot on! I disabled/removed the Native Dark theme and restarted Firefox, at which point it looks as I expected with a full dark toolbar, etc. So far so good. I'm a bit confused by how disabling this particular dark theme allowed the default dark theme to work again, but happy with the results. Thank you!

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: