Closed Bug 1591826 Opened 5 years ago Closed 5 years ago

Options page not in dark mode when dark theme is set in the browser

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Version:
70 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: oleg, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Enable Dark Theme in Firefox through Customize menu

Actual results:

Options page is still white

Expected results:

All internal pages like Options, about:config and so on should turn dark, just like they do if you set a system mode to Dark in Windows 10.

I have tested this on Windows 10 as well.

Component: Untriaged → Preferences

To make sure, you haven't mentioned what's your value of the browser.in-content.dark-mode preference which governs this.

Flags: needinfo?(oleg)

It is set to true.

Flags: needinfo?(oleg)

My understanding is that by default, Firefox will respect the OS's configuration for whether or not we should be in dark mode.

In order to override that, an additional setting is needed:

  1. Go to about:config
  2. Type ui.systemUsesDarkTheme into the filter bar
  3. Click the "Number" radio button, and press the "+" button to add the preference
  4. Set the value to 1

When I do that, I get dark content in about:preferences.

Am I right on the OS configuration thing, ntim?

Blocks: dark-incontent-pages
Flags: needinfo?(ntim.bugs)

Waiting on ntim to confirm, then I think we can probably close this as INVALID.

(In reply to Mike Conley (:mconley) (:⚙️) (Wayyyy behind on needinfos) from comment #4)

My understanding is that by default, Firefox will respect the OS's configuration for whether or not we should be in dark mode.

In order to override that, an additional setting is needed:

  1. Go to about:config
  2. Type ui.systemUsesDarkTheme into the filter bar
  3. Click the "Number" radio button, and press the "+" button to add the preference
  4. Set the value to 1

When I do that, I get dark content in about:preferences.

Am I right on the OS configuration thing, ntim?

Yes, this is correct.

Note that ui.systemUsesDarkTheme also overrides the value of prefers-color-scheme, which means websites that use it are also affected by the override.

If this bug is asking for the in-content pages to follow the browser dark theme as opposed to the OS dark theme, then this is a duplicate of bug 1529323.

Flags: needinfo?(ntim.bugs)

Thanks, ntim. Going to close this one as INVALID for now - wroot, please follow bug 1529323 if you think that that in-content pages should be aligned with the browser dark mode as opposed to OS dark mode.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.