Closed Bug 1591856 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19941 - [webnfc] Separate 'absolute-url' record type from 'url'

Categories

(Core :: DOM: Device Interfaces, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 19941 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19941
Details from upstream follow.

Leon Han <leon.han@intel.com> wrote:

[webnfc] Separate 'absolute-url' record type from 'url'

This CL introduces a new record type 'absolute-url' based on the spec
change: https://github.com/w3c/web-nfc/pull/373

Now we read/write records containing urls like:
'absolute-url' --> TNF_ABSOLUTE_URI
'url' --> TNF_WELL_KNOWN and RTD_URI

BUG=520391

Change-Id: I7b7a57c613eb1581efa01fd148c6083b26cd078a

Reviewed-on: https://chromium-review.googlesource.com/1881786
WPT-Export-Revision: 7d9ffdfd0e9c5c1d103b0a0b768d6ecc697c29af

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Result changes from PR not available.

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 7 tests and 95 subtests

Firefox

OK : 7
FAIL : 93

Chrome

OK : 7
PASS : 6
FAIL : 87

Safari

OK : 7
FAIL : 93

New tests that's don't pass

/web-nfc/NDEFWriter_push.https.html
NDEFWriter.push NDEFMessage containing text, json, opaque, url, absolute-url and external records with default NDEFPushOptions.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

/web-nfc/NDEFReader_options.https.html
Test that filtering 'absolute-url' record from different messages correctly with NDEFScanOptions' recordType is set to 'absolute-url'.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test that reading data succeed when NDEFScanOptions' recordType is set to 'absolute-url'.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

/web-nfc/NDEFRecord_constructor.https.html
NDEFRecord constructor with absolute-url record type: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Gecko CI Results

Ran 7 tests and 83 subtests
OK : 7
FAIL : 83

New tests that don't pass

/web-nfc/NDEFReader_options.https.html
Test that filtering 'absolute-url' record from different messages correctly with NDEFScanOptions' recordType is set to 'absolute-url'.: FAIL
Test that reading data succeed when NDEFScanOptions' recordType is set to 'absolute-url'.: FAIL
/web-nfc/NDEFRecord_constructor.https.html
NDEFRecord constructor with absolute-url record type: FAIL
/web-nfc/NDEFWriter_push.https.html
NDEFWriter.push NDEFMessage containing text, json, opaque, url, absolute-url and external records with default NDEFPushOptions.: FAIL

Automatic update from web-platform-tests
[webnfc] Separate 'absolute-url' record type from 'url'

This CL introduces a new record type 'absolute-url' based on the spec
change: https://github.com/w3c/web-nfc/pull/373

Now we read/write records containing urls like:
'absolute-url' --> TNF_ABSOLUTE_URI
'url' --> TNF_WELL_KNOWN and RTD_URI

BUG=520391

Change-Id: I7b7a57c613eb1581efa01fd148c6083b26cd078a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881786
Reviewed-by: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#711174}

--

wpt-commits: 0abb411331f86f472103183c7ec1136ea21a7e1b
wpt-pr: 19941

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf512f3978a2
[wpt PR 19941] - [webnfc] Separate 'absolute-url' record type from 'url', a=testonly
https://hg.mozilla.org/integration/autoland/rev/5035f017abfc
[wpt PR 19941] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.