Closed Bug 1591857 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 19942 - [WebNFC] Add tests for unformatted NDEF tag

Categories

(Core :: DOM: Device Interfaces, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 19942 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19942
Details from upstream follow.

Wanming Lin <wanming.lin@intel.com> wrote:

[WebNFC] Add tests for unformatted NDEF tag

This CL adds a few tests to cover various checkpoints:

  • Read/write data from/to an unformatted NDEF tag, as well as interaction with
    NDEFPushOptions.overwrite attribute.
  • Read/write data from/to a non-NDEF tag, throws error.

Relevant discussion in spec: https://github.com/w3c/web-nfc/issues/367

Bug: 520391, 1012463
Change-Id: I87cb7dc4611f8575b5616ecd98cc64249d79c4db

Reviewed-on: https://chromium-review.googlesource.com/1880537
WPT-Export-Revision: f2e0f4b1173d275ab72a8fc3cc3ef4e693f937a5

Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Result changes from PR not available.

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 2 tests and 53 subtests

Firefox

OK : 2
FAIL: 53

Chrome

OK : 2
FAIL: 53

Safari

OK : 2
FAIL: 53

New tests that's don't pass

/web-nfc/NDEFWriter_push.https.html
NDEFWriter.push should fail when the NFC device does not expose NDEF technology.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
NDEFWriter.push should fail when there are NDEF records on the NFC device and NDEFPushOptions.overwrite is false.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
NDEFWriter.push should succeed to push data to an unformatted NFC device when the NDEFPushOptions.overwrite is false.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
NDEFWriter.push should succeed to overwrite the existing data when the NDEFPushOptions.overwrite is true.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

/web-nfc/NDEFReader_scan.https.html
Test that NDEFReader.onreading should not be fired if the NFC tag does not expose NDEF technology.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
Test that NDEFReader.onreading should be fired on an unformatted NFC tag with empty records array for NDEFMessage.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Gecko CI Results

Ran 2 tests and 53 subtests
OK : 2
FAIL : 53

New tests that don't pass

/web-nfc/NDEFReader_scan.https.html
Test that NDEFReader.onreading should be fired on an unformatted NFC tag with empty records array for NDEFMessage.: FAIL
Test that NDEFReader.onreading should not be fired if the NFC tag does not expose NDEF technology.: FAIL
/web-nfc/NDEFWriter_push.https.html
NDEFWriter.push should fail when the NFC device does not expose NDEF technology.: FAIL
NDEFWriter.push should fail when there are NDEF records on the NFC device and NDEFPushOptions.overwrite is false.: FAIL
NDEFWriter.push should succeed to overwrite the existing data when the NDEFPushOptions.overwrite is true.: FAIL
NDEFWriter.push should succeed to push data to an unformatted NFC device when the NDEFPushOptions.overwrite is false.: FAIL

Automatic update from web-platform-tests
[WebNFC] Add tests for unformatted NDEF tag

This CL adds a few tests to cover various checkpoints:

  • Read/write data from/to an unformatted NDEF tag, as well as interaction with
    NDEFPushOptions.overwrite attribute.
  • Read/write data from/to a non-NDEF tag, throws error.

Relevant discussion in spec: https://github.com/w3c/web-nfc/issues/367

Bug: 520391, 1012463
Change-Id: I87cb7dc4611f8575b5616ecd98cc64249d79c4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880537
Commit-Queue: Wanming Lin <wanming.lin@intel.com>
Reviewed-by: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Leon Han <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#710249}

--

wpt-commits: e44f20914735498a05fc835efe3e2cbde9f86f00
wpt-pr: 19942

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46eaf54b8e0f
[wpt PR 19942] - [WebNFC] Add tests for unformatted NDEF tag, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3ee76345e9a8
[wpt PR 19942] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.