Celebration toast pop up is not triggered for the first milestone set
Categories
(Firefox :: Protections UI, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | unaffected |
firefox71 | --- | affected |
firefox72 | --- | affected |
People
(Reporter: cgeorgiu, Unassigned)
References
Details
Affected versions
- Latest Nightly 72.0a1
- Beta 71.0b5
Affected platforms
- Windows 10 x64
- macOS 10.13
- Ubuntu 18.04 x64
Preconditions
- Set
browser.contentblocking.cfr-milestone.milestones
to [15, 30, 50, 75, 100, 135, 150] - Make sure that
browser.contentblocking.cfr-milestone.milestone-achieved
is set to 0 - Set
browser.newtabpage.activity-stream.asrouter.providers.cfr
to {"id":"cfr","enabled":true,"type":"local","localProvider":"CFRMessageProvider","frequency":{"custom":[{"period":"daily","cap":10}]},"categories":["cfrAddons","cfrFeatures"],"updateCycleInMs":3600000} - Create and set
browser.contentblocking.cfr-milestone.update-interval
to 10
Steps to reproduce
- Visit https://www.reddit.com/
- Refreash the site for a couple of times until the cookies blocked hit the first milestone set, i.e. "15". This can be checked in Protection panel's UI.
Expected result
- The Celebration toast pop up is correctly shown.
Actual result
- The celebration toast pop up is not shown for the first milestone set. It seems that it's only displayed starting with the second milestone, i.e. "30".
Regression range
- Not a regression.
Comment 1•5 years ago
|
||
It seems to me like you need to clear history first/use a fresh profile to get a smaller number of blocked trackers in the database. Does that work?
Reporter | ||
Comment 2•5 years ago
|
||
No, unfortunately. I've tried several times already, using clean profiles or refreshing Firefox from about:support.
Comment 3•5 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Comment 4•5 years ago
|
||
This is because there is a check that requires the achieved milestone (and total number of trackers) to be at least 3000 away from the next milestone. This is to ensure we do not show the user the milestone message too often. This is as-designed.
Comment 5•5 years ago
|
||
Could you change the milestones to be [15, 5000, 10000, 20000] and then report back?
Reporter | ||
Comment 6•5 years ago
•
|
||
(In reply to Erica Wright [:ewright] from comment #5)
Could you change the milestones to be [15, 5000, 10000, 20000] and then report back?
Confirming that after changing the milestones as per above, the pop up is correctly shown. Thanks, Erica for clarifying this on comment 4 .
Comment 7•5 years ago
|
||
:ciprian_georgiu, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Description
•