1591887 - Upgrade Firefox 72 to use NSPR 4.24

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Kai Engert [:KaiE:]]

Upgrade Firefox 72 to use NSPR 4.24

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1591887 - NSPR_4_24_BETA1. r?jcj

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6db64ff6f63b
NSPR_4_24_BETA1. r=jcj

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/6db64ff6f63b

Comment 4

[Kai Engert [:KaiE:]]

I had forgotten to uplift a new snapshot to m-c for testing of bug 1586070. Let's do that now, and delay the RTM another few days.

Comment 5

[Kai Engert [:KaiE:]]

Attachment: Bug 1591887 - NSPR_4_24_BETA2. r?jcj

Comment 6

[J.C. Jones [:jcj] (he/they)]

[Tracking Requested - why for this release]:

Note that because https://wiki.mozilla.org/NSS:Release_Versions was wrong, since I was not aware of the schedule change on Firefox 72, this (and NSS in Bug 1592007) both missed the merge, and the Beta branch now has prerelease versions. Requesting Beta tracking on Kai's behalf, as we'll need to uplift the eventual RTM to not break all Linux distros (as already happened in https://bugzilla.mozilla.org/show_bug.cgi?id=1592007#c27)

Comment 7

[Kai Engert [:KaiE:]]

I think I can safely move the new NSPR changes to the next cycle.

I'll submit an updated uplift request for Beta that has zero risk, which will only change the version numbers.

Comment 8

[Kai Engert [:KaiE:]]

Attachment: Bug 1591887 - Uplift NSPR 4.24 RTM, only version number changes. r?jcj

Comment 9

[Kai Engert [:KaiE:]]

I'll land on autoland with lando.
How do I request beta uplift afterwards? Is that still be done with bugzilla flags on the attachment here in this bug?

Comment 10

[J.C. Jones [:jcj] (he/they)]

(In reply to Kai Engert (:KaiE:) from comment #9)

I'll land on autoland with lando.
How do I request beta uplift afterwards? Is that still be done with bugzilla flags on the attachment here in this bug?

Yes, works the same way. Probably good to give it a day on Nightly though.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10b295d8c610
Uplift NSPR 4.24 RTM, only version number changes. r=jcj

Comment 12

[J.C. Jones [:jcj] (he/they)]

Does NSS 3.48 need to depend on NSPR 4.24? Currently, it does not: https://hg.mozilla.org/projects/nss/file/tip/automation/release/nspr-version.txt

Comment 13

[Kai Engert [:KaiE:]]

(In reply to J.C. Jones [:jcj] (he/him) from comment #12)

Does NSS 3.48 need to depend on NSPR 4.24? Currently, it does not: https://hg.mozilla.org/projects/nss/file/tip/automation/release/nspr-version.txt

Yes it does!
NSPR introduces PR_ASSERT_ARG, which NSS redefines and uses as PORT_AssertArg in several places!

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/10b295d8c610

Comment 15

[Kai Engert [:KaiE:]]

Comment on attachment 9112974 [details]
Bug 1591887 - Uplift NSPR 4.24 RTM, only version number changes. r?jcj

Beta/Release Uplift Approval Request

• User impact if declined: linux distribution inconsistency
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): no functional change. Only adjusts final version number.
• String changes made/needed:

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 9112974 [details]
Bug 1591887 - Uplift NSPR 4.24 RTM, only version number changes. r?jcj

nspr dependency bump, approved for 72.0b3

Comment 17

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f7c6c838e79d