Closed Bug 1591887 Opened 4 months ago Closed 3 months ago

Upgrade Firefox 72 to use NSPR 4.24

Categories

(Firefox Build System :: General, task)

task
Not set

Tracking

(firefox72+ fixed, firefox73 fixed)

RESOLVED FIXED
mozilla73
Tracking Status
firefox72 + fixed
firefox73 --- fixed

People

(Reporter: KaiE, Assigned: KaiE)

References

Details

Attachments

(2 files, 1 obsolete file)

Upgrade Firefox 72 to use NSPR 4.24

Keywords: leave-open

I had forgotten to uplift a new snapshot to m-c for testing of bug 1586070. Let's do that now, and delay the RTM another few days.

Attached file Bug 1591887 - NSPR_4_24_BETA2. r?jcj (obsolete) —

[Tracking Requested - why for this release]:

Note that because https://wiki.mozilla.org/NSS:Release_Versions was wrong, since I was not aware of the schedule change on Firefox 72, this (and NSS in Bug 1592007) both missed the merge, and the Beta branch now has prerelease versions. Requesting Beta tracking on Kai's behalf, as we'll need to uplift the eventual RTM to not break all Linux distros (as already happened in https://bugzilla.mozilla.org/show_bug.cgi?id=1592007#c27)

I think I can safely move the new NSPR changes to the next cycle.

I'll submit an updated uplift request for Beta that has zero risk, which will only change the version numbers.

Attachment #9112665 - Attachment is obsolete: true

I'll land on autoland with lando.
How do I request beta uplift afterwards? Is that still be done with bugzilla flags on the attachment here in this bug?

(In reply to Kai Engert (:KaiE:) from comment #9)

I'll land on autoland with lando.
How do I request beta uplift afterwards? Is that still be done with bugzilla flags on the attachment here in this bug?

Yes, works the same way. Probably good to give it a day on Nightly though.

Pushed by kaie@kuix.de:
https://hg.mozilla.org/integration/autoland/rev/10b295d8c610
Uplift NSPR 4.24 RTM, only version number changes. r=jcj
Keywords: leave-open

Does NSS 3.48 need to depend on NSPR 4.24? Currently, it does not: https://hg.mozilla.org/projects/nss/file/tip/automation/release/nspr-version.txt

Flags: needinfo?(kaie)

(In reply to J.C. Jones [:jcj] (he/him) from comment #12)

Does NSS 3.48 need to depend on NSPR 4.24? Currently, it does not: https://hg.mozilla.org/projects/nss/file/tip/automation/release/nspr-version.txt

Yes it does!
NSPR introduces PR_ASSERT_ARG, which NSS redefines and uses as PORT_AssertArg in several places!

Flags: needinfo?(kaie)
Blocks: 1600803
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73

Comment on attachment 9112974 [details]
Bug 1591887 - Uplift NSPR 4.24 RTM, only version number changes. r?jcj

Beta/Release Uplift Approval Request

  • User impact if declined: linux distribution inconsistency
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): no functional change. Only adjusts final version number.
  • String changes made/needed:
Attachment #9112974 - Flags: approval-mozilla-beta?

Comment on attachment 9112974 [details]
Bug 1591887 - Uplift NSPR 4.24 RTM, only version number changes. r?jcj

nspr dependency bump, approved for 72.0b3

Attachment #9112974 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1601996
No longer regressions: 1601996
You need to log in before you can comment on or make changes to this bug.