Closed Bug 1591894 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19858 - Support IPv6 literals in KURL::SetHostAndPort

Categories

(Core :: DOM: Networking, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream][necko-triaged])

Attachments

(1 file)

Sync web-platform-tests PR 19858 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19858
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:

Support IPv6 literals in KURL::SetHostAndPort

KURL::SetHostAndPort would corrupt IPv6 literals because they contain
":" characters. Make it search for "]:" instead of just ":" to handle
IPv6 literals correctly.

Fallback to ":" characters for when the input does not contain an IPv6
literal.

Fixed: 1012416
Change-Id: If07a671b48c8c1b24b16883fb9072a86b0de7ebc

Reviewed-on: https://chromium-review.googlesource.com/1871449
WPT-Export-Revision: 05b8a012505383f0565694f6256fb93e127f0cc5

Component: web-platform-tests → DOM: Networking
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream error][necko-triaged]
Whiteboard: [wptsync downstream error][necko-triaged] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream][necko-triaged]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 595 subtests

Firefox

OK : 1
PASS: 379
FAIL: 216

Chrome

OK : 1
PASS: 299
FAIL: 296

Safari

OK : 1
PASS: 374
FAIL: 221

Firefox-only failures

/url/url-setters.html
<area>: Setting <mailto:me@example.net>.pathname = '/foo' Cannot-be-a-base don’t have a path: Firefox: FAIL
<area>: Setting <file://test/>.port = '12': Firefox: FAIL
URL: Setting <file://test/>.password = 'test': Firefox: FAIL
URL: Setting <file://test/>.port = '12': Firefox: FAIL
<a>: Setting <file://test/>.port = '12': Firefox: FAIL
<a>: Setting <mailto:me@example.net>.pathname = '/foo' Cannot-be-a-base don’t have a path: Firefox: FAIL
URL: Setting <file://test/>.username = 'test': Firefox: FAIL

Gecko CI Results

Ran 1 tests and 595 subtests
OK : 1
PASS : 379
FAIL : 216

Automatic update from web-platform-tests
Support IPv6 literals in KURL::SetHostAndPort

KURL::SetHostAndPort would corrupt IPv6 literals because they contain
":" characters. Make it check for "[]" characters and use the first ":"
after an IPv6 address as the start of the port number if one is present.

Fixed: 1012416
Change-Id: If07a671b48c8c1b24b16883fb9072a86b0de7ebc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871449
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710668}

--

wpt-commits: 5e2d3b33d4dc2d9221446c32c2fd6a3d79768406
wpt-pr: 19858

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba9a25564533
[wpt PR 19858] - Support IPv6 literals in KURL::SetHostAndPort, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.