Closed Bug 1591924 Opened 5 years ago Closed 5 years ago

Perma LATE BETA TEST-UNEXPECTED-FAIL | dom/notification/test/mochitest/test_notification_permissions.html | Test timed out. when Gecko 72 merges to Beta on 2019-12-02

Categories

(Toolkit Graveyard :: Notifications and Alerts, defect)

Product:
Toolkit Graveyard
Component:
Notifications and Alerts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox69 unaffected, firefox70 unaffected, firefox71 fixed, firefox72+ verified)

Status:
VERIFIED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox69 --- unaffected
firefox70 --- unaffected
firefox71 --- fixed
firefox72 + verified

People

(Reporter: apavel, Assigned: robwu)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1591924 - Fix test_notifications_permission.html on beta
47 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review

[Tracking Requested - why for this release]:

Central as Beta simulation:

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=16de5718efaa36447ce48b0db3251f7d9d6b5561&selectedJob=273220989

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=273220989&repo=try&lineNumber=2812

[task 2019-10-28T11:11:21.918Z] 11:11:21 INFO - TEST-START | dom/notification/test/mochitest/test_notification_permissions.html
[task 2019-10-28T11:11:21.933Z] 11:11:21 INFO - GECKO(1783) | ++DOMWINDOW == 10 (0x7ff83d2dac00) [pid = 1828] [serial = 10] [outer = 0x7ff84017e100]
[task 2019-10-28T11:11:22.464Z] 11:11:22 INFO - GECKO(1783) | [Child 1828, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1389
[task 2019-10-28T11:11:22.465Z] 11:11:22 INFO - GECKO(1783) | [Child 1828, Main Thread] WARNING: '!aWin', file /builds/worker/workspace/build/src/dom/base/Document.cpp, line 1389
[task 2019-10-28T11:11:22.962Z] 11:11:22 INFO - GECKO(1783) | ++DOMWINDOW == 11 (0x7ff83b21b000) [pid = 1828] [serial = 11] [outer = 0x7ff84017e100]
[task 2019-10-28T11:11:23.345Z] 11:11:23 INFO - GECKO(1783) | ++DOCSHELL 0x7ff83f29c800 == 4 [pid = 1828] [id = {3b9dccd8-2b9a-4670-b1a1-b60be573b913}]
[task 2019-10-28T11:11:23.345Z] 11:11:23 INFO - GECKO(1783) | ++DOMWINDOW == 12 (0x7ff83c164a60) [pid = 1828] [serial = 12] [outer = (nil)]
[task 2019-10-28T11:11:23.346Z] 11:11:23 INFO - GECKO(1783) | ++DOMWINDOW == 13 (0x7ff83bb04800) [pid = 1828] [serial = 13] [outer = 0x7ff83c164a60]
[task 2019-10-28T11:11:23.422Z] 11:11:23 INFO - GECKO(1783) | ++DOMWINDOW == 14 (0x7ff83d2db000) [pid = 1828] [serial = 14] [outer = 0x7ff83c164a60]
[task 2019-10-28T11:11:27.394Z] 11:11:27 INFO - GECKO(1783) | --DOMWINDOW == 13 (0x7ff83fa52400) [pid = 1828] [serial = 9] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:27.395Z] 11:11:27 INFO - GECKO(1783) | --DOMWINDOW == 12 (0x7ff83f2c8800) [pid = 1828] [serial = 5] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:27.396Z] 11:11:27 INFO - GECKO(1783) | --DOMWINDOW == 11 (0x7ff83f2c6400) [pid = 1828] [serial = 3] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:27.396Z] 11:11:27 INFO - GECKO(1783) | --DOMWINDOW == 10 (0x7ff83f112400) [pid = 1828] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:29.181Z] 11:11:29 INFO - GECKO(1783) | --DOMWINDOW == 10 (0x7f1b19436400) [pid = 1783] [serial = 10] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:29.182Z] 11:11:29 INFO - GECKO(1783) | --DOMWINDOW == 9 (0x7f1b1b6f0000) [pid = 1783] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:29.183Z] 11:11:29 INFO - GECKO(1783) | --DOMWINDOW == 8 (0x7f1b19434800) [pid = 1783] [serial = 9] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:31.490Z] 11:11:31 INFO - GECKO(1783) | --DOMWINDOW == 9 (0x7ff83d2dac00) [pid = 1828] [serial = 10] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:31.491Z] 11:11:31 INFO - GECKO(1783) | --DOMWINDOW == 8 (0x7ff83bb04800) [pid = 1828] [serial = 13] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:33.781Z] 11:11:33 INFO - GECKO(1783) | --DOMWINDOW == 8 (0x7f29e04e0000) [pid = 1884] [serial = 2] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:33.782Z] 11:11:33 INFO - GECKO(1783) | --DOMWINDOW == 7 (0x7f29e0387000) [pid = 1884] [serial = 4] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:11:33.782Z] 11:11:33 INFO - GECKO(1783) | --DOMWINDOW == 6 (0x7f29e0389800) [pid = 1884] [serial = 6] [outer = (nil)] [url = about:blank]
[task 2019-10-28T11:16:21.919Z] 11:16:21 INFO - TEST-INFO | started process screentopng
[task 2019-10-28T11:16:22.268Z] 11:16:22 INFO - TEST-INFO | screentopng: exit 0
[task 2019-10-28T11:16:22.269Z] 11:16:22 INFO - Buffered messages logged at 11:11:23
[task 2019-10-28T11:16:22.269Z] 11:16:22 INFO - add_task | Entering test test_notifications_permission
[task 2019-10-28T11:16:22.270Z] 11:16:22 INFO - Buffered messages finished
[task 2019-10-28T11:16:22.270Z] 11:16:22 INFO - TEST-UNEXPECTED-FAIL | dom/notification/test/mochitest/test_notification_permissions.html | Test timed out.
[task 2019-10-28T11:16:22.270Z] 11:16:22 INFO - SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:277:18
[task 2019-10-28T11:16:22.270Z] 11:16:22 INFO - reportError@https://example.com/tests/SimpleTest/TestRunner.js:121:22
[task 2019-10-28T11:16:22.270Z] 11:16:22 INFO - TestRunner._checkForHangs@https://example.com/tests/SimpleTest/TestRunner.js:142:18
[task 2019-10-28T11:16:22.928Z] 11:16:22 INFO - GECKO(1783) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2019-10-28T11:16:22.928Z] 11:16:22 INFO - GECKO(1783) | MEMORY STAT | vsize 2542MB | residentFast 153MB | heapAllocated 19MB

This appears to be a regression of bug 1589754, Rob please take a look.
[task 2019-10-28T11:16:24.939Z] 11:16:24 INFO - TEST-OK | dom/notification/test/mochitest/test_notification_permissions.html | took 303028ms

Flags: needinfo?(rob)

FWIW, I have just found that IsTopWindow seems not to work in fission. It returns GetInProcessScriptableTop and wrong in oop iframe. But I guess it's not related here. Basically, since that is failed in beta only, I guess it would be related to prefs permissions.delegation.enable or dom.featurepolicy.enable (because those are only enabled in nightly)

The failure occurred because the dom.webnotifications.requireuserinteraction pref defaults to false on Beta/release - https://searchfox.org/mozilla-central/rev/11d9c7b7fa82fdfb8ac2a8f0864e9d8d5fe2b926/modules/libpref/init/StaticPrefList.yaml#2640-2642

I consistently reproduced on m-c by explicitly setting dom.webnotifications.requireuserinteraction to false. Fixing it to true fixes the issue.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Flags: needinfo?(rob)
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/65b8ca82b533
Fix test_notifications_permission.html on beta r=tnguyen

https://hg.mozilla.org/mozilla-central/rev/65b8ca82b533

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Comment on attachment 9104701 [details]
Bug 1591924 - Fix test_notifications_permission.html on beta

Beta/Release Uplift Approval Request

  • User impact if declined: If the patch for bug 1589754 is merged, then the new test will fail on Beta unless this patch is included as well.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): test-only change, locally verified.
  • String changes made/needed: none
Attachment #9104701 - Flags: approval-mozilla-beta?
Status: RESOLVED → VERIFIED
status-firefox72: fixed → verified

Comment on attachment 9104701 [details]
Bug 1591924 - Fix test_notifications_permission.html on beta

Uplift approved for 71 beta 6, thanks.

Attachment #9104701 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Has Regression Range: --- → yes
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: