1591965 - Investigate lib-crash invalid value errors in Fenix

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Comment 1

[Travis Long [:travis_]]

The way that this is implemented in lib-crash, it's counting all of the recorded errors in the persisted file and then calling add(<number of errors>), which could potentially be zero, and calling add(0) is an invalid_value error.

Comment 2

[Travis Long [:travis_]]

Attachment: GitHub Pull Request

Comment 3

[Travis Long [:travis_]]

This is still happening at a low/lower frequency, reopening this to investigate again.

Comment 4

[Travis Long [:travis_]]

Looking at this more closely using our error dashboards, it doesn't appear that we have had an instance of this occur in Fenix nightly since the 19th, and have seen a sharp falloff of occurrences just before that. This is even better if filtering for versions of Fenix using Glean-core.

Even looking at this in FF-Preview Release, we are starting to see a downward trend in both counts and affected clients.

Based on Nightly showing little or no occurrences, and based on the trend in Release towards zero, I'm closing this as fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8f7b5e9eec4
[components] 1591965 - Fixes an issue in lib-crash recording Glean errors