Closed Bug 1592005 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19856 - Support for Canvas and Text system color keywords

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 19856 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19856
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

Support for Canvas and Text system color keywords

Add support for the new system color names, Canvas and Text. Canvas
maps to the Window system color, and Text maps to WindowText.

Text was already added as a system color previously, and was
mapped to a separate value than WindowText for Mac. This mapping
was left as-is for Mac.

Spec: https://drafts.csswg.org/css-color-4/#css-system-colors

Intent-to-ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-apVTp8jBi0

Bug: 1015968
Change-Id: I0047e6b6d6c87f13f556d5ad147d9c4be421a592
Reviewed-on: https://chromium-review.googlesource.com/1864378
WPT-Export-Revision: e5729f7765e1fbae769e60bb7fc73a0ca7590461

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 1 tests and 12 subtests

Firefox

OK : 1
PASS: 7
FAIL: 5

Chrome

OK : 1
PASS: 10
FAIL: 2

Safari

OK : 1
PASS: 5
FAIL: 7

New tests that's don't pass

/css/css-color/parsing/system-color-valid.html
e.style['color'] = "VisitedText" should set the property value: Firefox: FAIL, Chrome: PASS, Safari: FAIL
e.style['color'] = "ActiveText" should set the property value: Firefox: FAIL, Chrome: PASS, Safari: FAIL
e.style['color'] = "CanvasText" should set the property value: Firefox: FAIL, Chrome: FAIL, Safari: FAIL
e.style['color'] = "LinkText" should set the property value: Firefox: FAIL, Chrome: PASS, Safari: FAIL
e.style['color'] = "Canvas" should set the property value: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e969f8142076
[wpt PR 19856] - Support for Canvas and CanvasText system color keywords, a=testonly
https://hg.mozilla.org/integration/autoland/rev/3c892de7af99
[wpt PR 19856] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.