Closed Bug 1592071 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19955 - [scroll-snap] Make tests independent of scrollbar

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 19955 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19955
Details from upstream follow.

Majid Valipour <majidvp@chromium.org> wrote:

[scroll-snap] Make tests independent of scrollbar

Multiple scroll snap wpt tests use scrollbar-width:none css property
to hide scrollbars. This property is only supported in Gecko.

This CL adds the legacy webkit prefixed property [1] to have the same
functionality. This addition allows 7 tests to pass in Chrome
(and potentially in Safari).

[1] ::-webkit-scrollar { display: none; }

Fixed: 1003055
Change-Id: Iefe5f5071d23cd40bab71a9d0e360b62e10e9c73
Reviewed-on: https://chromium-review.googlesource.com/1884816
WPT-Export-Revision: 6770c64bb3e9307df2fa1d7a9f7aa5123b587d6c

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 12 tests

Firefox

PASS: 6
FAIL: 6

Chrome

PASS: 8
FAIL: 4

Safari

FAIL: 12

Gecko CI Results

Ran 12 tests
PASS : 4[linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-qr-opt], 6[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows7-32-debug,windows7-32-opt]
FAIL : 4[linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-qr-opt], 6[android-em-7.0-x86_64-debug-geckoview,android-em-7.0-x86_64-opt-geckoview,linux64-asan-opt,linux64-debug,windows10-64-debug,windows10-64-opt,windows10-64-qr-debug,windows7-32-debug,windows7-32-opt]
ERROR : 4[linux64-opt,linux64-qr-debug,linux64-qr-opt,windows10-64-qr-opt]

Existing tests that now have a worse result

/css/css-scroll-snap/scroll-target-align-001.html: ERROR[linux64-opt,linux64-qr-opt]
/css/css-scroll-snap/scroll-target-margin-001.html: ERROR[linux64-opt,linux64-qr-opt]
/css/css-scroll-snap/scroll-target-padding-001.html: ERROR[linux64-opt,linux64-qr-opt]
/css/css-scroll-snap/scroll-target-snap-001.html: ERROR[linux64-opt,linux64-qr-opt]

Automatic update from web-platform-tests
[scroll-snap] Make several wpt tests independent of scrollbar-width

Multiple scroll snap wpt tests use scrollbar-width:none css property
to hide scrollbars. This property is only supported in Gecko.

This CL adds the legacy webkit prefixed property [1] to enable the same
functionality. This addition allows 8 existing tests to pass in Chrome (and
potentially in Safari).

[1] ::-webkit-scrollar { display: none; }

Fixed: 1003055
Change-Id: Iefe5f5071d23cd40bab71a9d0e360b62e10e9c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884816
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711384}

--

wpt-commits: dc048c67d786f646ab659ea050183989ff3e8bfb
wpt-pr: 19955

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16b52f0c8183
[wpt PR 19955] - [scroll-snap] Make several wpt tests independent of scrollbar-width, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.