1592121 - Crash in [@ webrender::batch::BatchBuilder::add_segment_to_batch]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-2e2240e2-3ac9-4078-87cf-55e4d0191028.

Top 10 frames of crashing thread:

0 XUL gkrust_shared::panic_hook mfbt/Assertions.h:332
1 XUL core::ops::function::Fn::call src/libcore/ops/function.rs:69
2 XUL std::panicking::rust_panic_with_hook src/libstd/panicking.rs:481
3 XUL std::panicking::continue_panic_fmt src/libstd/panicking.rs:384
4 XUL rust_begin_unwind src/libstd/panicking.rs:311
5 XUL core::panicking::panic_fmt src/libcore/panicking.rs:85
6 XUL core::panicking::panic_bounds_check src/libcore/panicking.rs:61
7 XUL webrender::batch::BatchBuilder::add_segment_to_batch gfx/wr/webrender/src/batch.rs:2417
8 XUL webrender::batch::BatchBuilder::add_segmented_prim_to_batch gfx/wr/webrender/src/batch.rs:2481
9 XUL webrender::batch::BatchBuilder::add_prim_to_batch gfx/wr/webrender/src/batch.rs

There are 12 crashes (from 6 installations) in nightly 72 with buildid 20191028094851. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1590284.

[1] https://hg.mozilla.org/mozilla-central/rev?node=60e6c61a7f45

Comment 1

[Glenn Watson [:gw]]

Do we have any URLs / repro steps for this one?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

All of them are google drive urls.

Comment 3

[Glenn Watson [:gw]]

Attachment: Bug 1592121 - Ensure prim instances in culled clusters are reset.

This prevents stale indices into the prim visibility scratch
buffer being reused on subsequent frames, which can cause various
unexpected code paths to be hit.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking for 72 given the volume

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59fc72700a93
Ensure prim instances in culled clusters are reset. r=nical

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/59fc72700a93