1592137 - [wpt-sync] Sync PR 19960 - Remove inDocument check for emitting change events

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19960 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19960
Details from upstream follow.

Joey Arhar <[e-mail]> wrote:

Remove inDocument check for emitting change events

The html spec does not seem to say anything against emitting change
events for input elements which are detached from the DOM. It does say
that immutable input elements should not have change events emitted for
them, but I don't think that having it detached from the DOM means that
it is immutable, especially since we can successfully change the
.checked value while detached from the dom.

Bug: 773680
Change-Id: Ie579ed1f3c34fc03f74554a5685f40c510805f2a
Reviewed-on: https://chromium-review.googlesource.com/1885093
WPT-Export-Revision: ea181a7f58819c41f07cca83ddbf0ebb136ae4cf

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=52b09cd214a811277742d2e7e5a07ad861a16ff5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 2 tests and 2 subtests

Firefox

OK : 2
PASS: 2

Chrome

TIMEOUT: 4

Safari

TIMEOUT: 4

Gecko CI Results

Ran 2 tests and 2 subtests
OK : 2
PASS : 2

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1592137 [wpt PR 19960] - Remove inDocument check for emitting change events, a=testonly

Automatic update from web-platform-tests
Remove inDocument check for emitting change events

The html spec does not seem to say anything against emitting change
events for input elements which are detached from the DOM. It does say
that immutable input elements should not have change events emitted for
them, but I don't think that having it detached from the DOM means that
it is immutable, especially since we can successfully change the
.checked value while detached from the dom.

Bug: 773680
Change-Id: Ie579ed1f3c34fc03f74554a5685f40c510805f2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885093
Reviewed-by: Kent Tamura <[e-mail]>
Reviewed-by: Mason Freed <[e-mail]>
Commit-Queue: Joey Arhar <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#710642}

--

wpt-commits: f2f0130e56d6893099b8e0c51fc82bc2ab4b1ce2
wpt-pr: 19960

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e965792fc82
[wpt PR 19960] - Remove inDocument check for emitting change events, a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2e965792fc82