Closed Bug 1592137 Opened 11 months ago Closed 10 months ago

[wpt-sync] Sync PR 19960 - Remove inDocument check for emitting change events

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 19960 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19960
Details from upstream follow.

Joey Arhar <jarhar@chromium.org> wrote:

Remove inDocument check for emitting change events

The html spec does not seem to say anything against emitting change
events for input elements which are detached from the DOM. It does say
that immutable input elements should not have change events emitted for
them, but I don't think that having it detached from the DOM means that
it is immutable, especially since we can successfully change the
.checked value while detached from the dom.

Bug: 773680
Change-Id: Ie579ed1f3c34fc03f74554a5685f40c510805f2a
Reviewed-on: https://chromium-review.googlesource.com/1885093
WPT-Export-Revision: ea181a7f58819c41f07cca83ddbf0ebb136ae4cf

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 2 tests and 2 subtests

Firefox

OK : 2
PASS: 2

Chrome

TIMEOUT: 4

Safari

TIMEOUT: 4

Gecko CI Results

Ran 2 tests and 2 subtests
OK : 2
PASS : 2

Automatic update from web-platform-tests
Remove inDocument check for emitting change events

The html spec does not seem to say anything against emitting change
events for input elements which are detached from the DOM. It does say
that immutable input elements should not have change events emitted for
them, but I don't think that having it detached from the DOM means that
it is immutable, especially since we can successfully change the
.checked value while detached from the dom.

Bug: 773680
Change-Id: Ie579ed1f3c34fc03f74554a5685f40c510805f2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885093
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710642}

--

wpt-commits: f2f0130e56d6893099b8e0c51fc82bc2ab4b1ce2
wpt-pr: 19960

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e965792fc82
[wpt PR 19960] - Remove inDocument check for emitting change events, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.