Closed Bug 1592140 Opened 9 months ago Closed 6 months ago

Flip the H.264 Platform encoder prefs on Android

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox-esr68 - wontfix
firefox73 --- fixed
firefox74 --- fixed

People

(Reporter: jhlin, Assigned: jhlin)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Two prefs are needed: media.webrtc.platformencoder and media.webrtc.hw.h264.enabled.

Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f116128f81b
enable platform encoder and HW H.264 support on Android. r=jya
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d73cfe3a04e9
Backed out changeset 1f116128f81b for causing multiple mda2 Android 8.0 failures. CLOSED TREE
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/382a205bcb3e
enable platform encoder and HW H.264 support on Android. r=jya
https://hg.mozilla.org/integration/autoland/rev/998ab0bd0e35
p2: disable HW H.264 support for certain tests. r=pehrsons

Looks like ESLint doesn't like the original formatting I copied from above. Will update and try landing again.

Flags: needinfo?(jolin)
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efe989cdf146
enable platform encoder and HW H.264 support on Android. r=jya
https://hg.mozilla.org/integration/autoland/rev/edb87ed43383
p2: disable HW H.264 support for certain tests. r=pehrsons
See Also: → 1599799

I'm assuming this work is targeting GeckoView/Fenix and not Fennec. Setting ESR68 status accordingly.

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jhlin, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jolin)

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #11)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jhlin, could you have a look please?
For more information, please visit auto_nag documentation.

The patches needs bug 1599799 to be landed.

Flags: needinfo?(jolin)
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/65db57bdc16b
enable platform encoder and HW H.264 support on Android. r=jya
https://hg.mozilla.org/integration/autoland/rev/c789df12feec
p2: disable HW H.264 support for certain tests. r=pehrsons
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

Comment on attachment 9106751 [details]
Bug 1592140 - enable platform encoder and HW H.264 support on Android. r?jya

Beta/Release Uplift Approval Request

  • User impact if declined: GeckoView-based app won't be able to talk with WebRTC apps that support only H.264 video.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1599799
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The feature has passed QA tests in the fx71 cycle with minor following code changes that addresses automation test failures.
  • String changes made/needed: N/A
Attachment #9106751 - Flags: approval-mozilla-beta?
Attachment #9109195 - Flags: approval-mozilla-beta?

Comment on attachment 9106751 [details]
Bug 1592140 - enable platform encoder and HW H.264 support on Android. r?jya

Enables using the Android platform decoder for H264 WebRTC calls (which was previously covered by OpenH264 until support was removed). Approved for GV73.

Attachment #9106751 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9109195 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.