1592140 - Flip the H.264 Platform encoder prefs on Android

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[John Lin [:jhlin][:jolin]]

Two prefs are needed: media.webrtc.platformencoder and media.webrtc.hw.h264.enabled.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1592140 - enable platform encoder and HW H.264 support on Android. r?jya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f116128f81b
enable platform encoder and HW H.264 support on Android. r=jya

Comment 3

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d73cfe3a04e9
Backed out changeset 1f116128f81b for causing multiple mda2 Android 8.0 failures. CLOSED TREE

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1592140 - p2: disable HW H.264 support for certain tests. r?pehrsons

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/382a205bcb3e
enable platform encoder and HW H.264 support on Android. r=jya
https://hg.mozilla.org/integration/autoland/rev/998ab0bd0e35
p2: disable HW H.264 support for certain tests. r=pehrsons

Comment 6

[Razvan Maries]

Backed out for ES Lint failure on head.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=277051610&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linting%2Copt%2Cjavascript%2Cchecks%2Csource-test-mozlint-eslint%2Cjs%28es%29&revision=998ab0bd0e35beee827d02f3fde27948c83c243f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277051610&repo=autoland&lineNumber=55

Backout: https://hg.mozilla.org/integration/autoland/rev/08ad786aea866a6f9b029812f326f9644d98ea00

Comment 7

[John Lin [:jhlin][:jolin]]

Looks like ESLint doesn't like the original formatting I copied from above. Will update and try landing again.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/efe989cdf146
enable platform encoder and HW H.264 support on Android. r=jya
https://hg.mozilla.org/integration/autoland/rev/edb87ed43383
p2: disable HW H.264 support for certain tests. r=pehrsons

Comment 9

[Andreea Pavel [:apavel]]

Backed out for failing test_peerConnection_bug1512281.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedJob=277110101&resultStatus=testfailed%2Cbusted%2Cexception&revision=f4a9e675a33f01ce97adce2296b9b21ce5e3111f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=277110101&repo=autoland&lineNumber=2917

Backout: https://hg.mozilla.org/integration/autoland/rev/26dedaf63bf56ad57d1ecb2a72fc6c87ca3d0765

Comment 10

[Ryan VanderMeulen [:RyanVM]]

I'm assuming this work is targeting GeckoView/Fenix and not Fennec. Setting ESR68 status accordingly.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jhlin, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 12

[John Lin [:jhlin][:jolin]]

(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #11)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jhlin, could you have a look please?
For more information, please visit auto_nag documentation.

The patches needs bug 1599799 to be landed.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65db57bdc16b
enable platform encoder and HW H.264 support on Android. r=jya
https://hg.mozilla.org/integration/autoland/rev/c789df12feec
p2: disable HW H.264 support for certain tests. r=pehrsons

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/65db57bdc16b
https://hg.mozilla.org/mozilla-central/rev/c789df12feec

Comment 15

[John Lin [:jhlin][:jolin]]

Comment on attachment 9106751 [details]
Bug 1592140 - enable platform encoder and HW H.264 support on Android. r?jya

Beta/Release Uplift Approval Request

• User impact if declined: GeckoView-based app won't be able to talk with WebRTC apps that support only H.264 video.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1599799
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The feature has passed QA tests in the fx71 cycle with minor following code changes that addresses automation test failures.
• String changes made/needed: N/A

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9106751 [details]
Bug 1592140 - enable platform encoder and HW H.264 support on Android. r?jya

Enables using the Android platform decoder for H264 WebRTC calls (which was previously covered by OpenH264 until support was removed). Approved for GV73.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/df501ed38e3b
https://hg.mozilla.org/releases/mozilla-beta/rev/f2cdf0194fb1