Closed Bug 1592182 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19968 - CSS: Update min-width and min-height parsing WPTs

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Bug 1592182 [wpt PR 19968] - CSS: Update min-width and min-height parsing WPTs, a=testonly
47 bytes, text/x-phabricator-request
Details | Review

Sync web-platform-tests PR 19968 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19968
Details from upstream follow.

Eric Willigers <ericwilligers@chromium.org> wrote:

CSS: Update min-width and min-height parsing WPTs

min-width and min-height were previously defined in
https://drafts.csswg.org/css-box-3/
They supported 'fit-content' as a keyword, not as a function.
[ [\<length> | \<percentage>] && [border-box | content-box]? ] | available | min-content | max-content | fit-content

Now min-width and min-height are exclusively defined in
https://drafts.csswg.org/css-sizing-3/
They support fit-width as a function, not as a keyword.
auto | \<length-percentage> | min-content | max-content | fit-content(\<length-percentage>)

Bug: 856648
Change-Id: I04230a5a530b1455fbd17bbf0aceeabacdd188d4
Reviewed-on: https://chromium-review.googlesource.com/1885860
WPT-Export-Revision: be07a36bf8a55f8824d748bde9ae6fa9ce23026a

Component: web-platform-tests → Layout
Product: Testing → Core

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 6 tests and 62 subtests

Firefox

OK : 2
PASS : 24

Chrome

OK : 2
PASS : 22
FAIL : 2

Safari

OK : 2
PASS : 22
FAIL : 2

Existing tests that now have a worse result

/css/css-box/parsing/min-height-valid.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING
e.style['min-height'] = "20%" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "max-content" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "min-content" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "10px" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "calc(2em + 3ex)" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/css/css-box/parsing/min-width-valid.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING
e.style['min-width'] = "min-content" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "10px" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "max-content" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "20%" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "calc(2em + 3ex)" should set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/css/css-box/parsing/min-width-invalid.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING
e.style['min-width'] = "60" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "content-box 20% border-box" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "-10px" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "20% available" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "max-content 10px" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "complex" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "content-box border-box" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "none" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "10px 20%" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "10px border-box 20%" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "none available" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-width'] = "-20%" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

/css/css-box/parsing/min-height-invalid.html: Firefox: OK->MISSING, Chrome: OK->MISSING, Safari: OK->MISSING
e.style['min-height'] = "-20%" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "10px border-box 20%" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "none" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "10px 20%" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "none available" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "content-box 20% border-box" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "20% available" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "60" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "complex" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "content-box border-box" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "-10px" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING
e.style['min-height'] = "max-content 10px" should not set the property value: Firefox: PASS->MISSING, Chrome: PASS->MISSING, Safari: PASS->MISSING

Automatic update from web-platform-tests
CSS: Update min-width and min-height parsing WPTs

min-width and min-height were previously defined in
https://drafts.csswg.org/css-box-3/
They supported 'fit-content' as a keyword, not as a function.
[ [<length> | <percentage>] && [border-box | content-box]? ] | available | min-content | max-content | fit-content

Now min-width and min-height are exclusively defined in
https://drafts.csswg.org/css-sizing-3/
They support fit-width as a function, not as a keyword.
auto | <length-percentage> | min-content | max-content | fit-content(<length-percentage>)

Bug: 856648
Change-Id: I04230a5a530b1455fbd17bbf0aceeabacdd188d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885860
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711067}

--

wpt-commits: f2b9fd8d016b3c06806b2eb6065ff4b1d73cf2c0
wpt-pr: 19968

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db8d9ac147c7
[wpt PR 19968] - CSS: Update min-width and min-height parsing WPTs, a=testonly

https://hg.mozilla.org/mozilla-central/rev/db8d9ac147c7

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: