1592215 - [wpt-sync] Sync PR 19974 - [webnfc] Add BufferSource into the union type NDEFMessageSource

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 19974 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19974
Details from upstream follow.

Leon Han <[e-mail]> wrote:

[webnfc] Add BufferSource into the union type NDEFMessageSource

This CL updates the definition of the union type NDEFMessageSource:
(DOMString or ArrayBuffer or NDEFMessageInit)
==>
(DOMString or BufferSource or NDEFMessageInit)

BUG=520391

Change-Id: I603616047814c56744eed94efd7f3579079b0875

Reviewed-on: https://chromium-review.googlesource.com/1886351
WPT-Export-Revision: da8780c4f098620ae5a3391cfed3bc7d8db761f1

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 19974 applied with additional changes from upstream: ad93565efd7161ee146a44e92c02d7339dbaf8e1, e44f20914735498a05fc835efe3e2cbde9f86f00

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=86d183bd46b6cc499efa2655c5189c6579046baa

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Result changes from PR not available.

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 7 tests and 94 subtests

Firefox

OK : 7
FAIL: 94

Chrome

OK : 7
PASS: 33
FAIL: 61

Safari

OK : 7
FAIL: 94

New tests that's don't pass

/web-nfc/NDEFWriter_push.https.html
Test that NDEFWriter.push succeeds when message is ArrayBufferView.: Firefox: FAIL, Chrome: FAIL, Safari: FAIL

Gecko CI Results

Ran 7 tests and 88 subtests
OK : 7
FAIL : 88

New tests that don't pass

/web-nfc/NDEFReader_scan.https.html
Test that NDEFReader.onreading should be fired on an unformatted NFC tag with empty records array for NDEFMessage.: FAIL
Test that NDEFReader.onreading should not be fired if the NFC tag does not expose NDEF technology.: FAIL
/web-nfc/NDEFWriter_push.https.html
NDEFWriter.push should fail when the NFC device does not expose NDEF technology.: FAIL
NDEFWriter.push should fail when there are NDEF records on the NFC device and NDEFPushOptions.overwrite is false.: FAIL
NDEFWriter.push should succeed to overwrite the existing data when the NDEFPushOptions.overwrite is true.: FAIL
NDEFWriter.push should succeed to push data to an unformatted NFC device when the NDEFPushOptions.overwrite is false.: FAIL
Test that NDEFWriter.push succeeds when message is ArrayBufferView.: FAIL

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1592215 [wpt PR 19974] - [webnfc] Add BufferSource into the union type NDEFMessageSource, a=testonly

Automatic update from web-platform-tests
[webnfc] Add BufferSource into the union type NDEFMessageSource

This CL updates the definition of the union type NDEFMessageSource:
(DOMString or ArrayBuffer or NDEFMessageInit)
==>
(DOMString or BufferSource or NDEFMessageInit)

BUG=520391

Change-Id: I603616047814c56744eed94efd7f3579079b0875
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886351
Reviewed-by: Reilly Grant <[e-mail]>
Reviewed-by: Yuki Shiino <[e-mail]>
Commit-Queue: Leon Han <[e-mail]>
Cr-Commit-Position: refs/heads/master@{#711986}

--

wpt-commits: c0ec46c3e6f1452abf3cf9916f3e2ceb4c494b12
wpt-pr: 19974

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Bug 1592215 [wpt PR 19974] - Update wpt metadata, a=testonly

wpt-pr: 19974
wpt-type: metadata

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c340e6fbf2a
[wpt PR 19974] - [webnfc] Add BufferSource into the union type NDEFMessageSource, a=testonly
https://hg.mozilla.org/integration/autoland/rev/86ef2730e19d
[wpt PR 19974] - Update wpt metadata, a=testonly

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2c340e6fbf2a
https://hg.mozilla.org/mozilla-central/rev/86ef2730e19d