Closed Bug 1592253 Opened 9 months ago Closed 9 months ago

Remove the unused Fennec telemetry probes

Categories

(Firefox for Android :: General, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(2 files)

No description provided.

We still depend on Fennec telemetry. Can we delay this or let these expire when we ultimately replace Fennec?

Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31d3e3068c32
Remove the unused Fennec telemetry probes; r=snorp

(In reply to Stefan Arentz [:st3fan] from comment #2)

We still depend on Fennec telemetry. Can we delay this or let these expire when we ultimately replace Fennec?

Oh, sorry I landed this before I saw your comment. Yes, there's no rush at all, it just wasn't obvious that these are used.

I'll back out the patch for now.

Flags: needinfo?(ehsan)

For the record, removing these from Histograms.json doesn't stop the data from being collected on Fennec. Fennec is on esr68, and so long as this patch doesn't get rebased and merged onto that branch, Fennec will go on collecting these probes.

Backout by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/206089a73823
Backout changeset 31d3e3068c32 because we still depend on these probes

(In reply to Chris H-C :chutten from comment #6)

For the record, removing these from Histograms.json doesn't stop the data from being collected on Fennec. Fennec is on esr68, and so long as this patch doesn't get rebased and merged onto that branch, Fennec will go on collecting these probes.

So does this mean that I can land this patch?

Flags: needinfo?(chutten)

Yes. Though I'd like to make sure I understand Stefan properly first.

What are your concerns about removing these probe definitions from Histograms.json? The data will continue to be collected for Fennec builds already out there, and unless this patch is merged to esr68 then this should continue through the lifetime of the product.

Flags: needinfo?(chutten) → needinfo?(sarentz)

unless this patch is merged to esr68

(which I never intended to do, FWIW...)

(In reply to Chris H-C :chutten from comment #9)

Yes. Though I'd like to make sure I understand Stefan properly first.

What are your concerns about removing these probe definitions from Histograms.json? The data will continue to be collected for Fennec builds already out there, and unless this patch is merged to esr68 then this should continue through the lifetime of the product.

Yes, that is totally fine. Sorry for the confusion.

Flags: needinfo?(sarentz)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8449ec58f40f
Remove the unused Fennec telemetry probes; r=snorp

Backed out for bustages on TelemetryHistogramEnums.h

backout: https://hg.mozilla.org/integration/autoland/rev/787484b40d10480d0d375604595c8734e550c70e

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8449ec58f40f26b421fe001898257f344b1c3e02&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=274031533&repo=autoland&lineNumber=3878

[task 2019-11-01T07:23:11.334Z] 07:23:11 INFO - New histogram "FETCH_IS_MAINTHREAD" must have a "bug_numbers" field.
[task 2019-11-01T07:23:11.335Z] 07:23:11 INFO - Some errors occurred
[task 2019-11-01T07:23:11.335Z] 07:23:11 INFO - Exception KeyError: KeyError(139830355076864,) in <module 'threading' from '/usr/lib/python2.7/threading.pyc'> ignored
[task 2019-11-01T07:23:11.335Z] 07:23:11 INFO - backend.mk:21: recipe for target '.deps/TelemetryHistogramEnums.h.stub' failed
[task 2019-11-01T07:23:11.335Z] 07:23:11 ERROR - make[4]: *** [.deps/TelemetryHistogramEnums.h.stub] Error 1
[task 2019-11-01T07:23:11.335Z] 07:23:11 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/telemetry'
[task 2019-11-01T07:23:11.335Z] 07:23:11 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-11-01T07:23:11.451Z] 07:23:11 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/xpcom/base'
[task 2019-11-01T07:23:11.451Z] 07:23:11 INFO - xpcom/base/gk_rust_utils_ffi_generated.h.stub

Flags: needinfo?(ehsan)
See Also: → 1577863
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/409ae38a1761
Remove the unused Fennec telemetry probes; r=snorp
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.