Closed Bug 1592294 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 19978 - Force error page to be classified as cross-document.

Categories

(Core :: DOM: Security, task, P4)

Product:
Core
Component:
DOM: Security
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Sync web-platform-tests PR 19978 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/19978
Details from upstream follow.

arthursonzogni <arthursonzogni@chromium.org> wrote:

Force error page to be classified as cross-document.

Bug https://crbug.com/1018385 is caused by navigation initially
classified as "same-document" committing error pages.

During the commit phase of the navigation, the NavigationRequest is
transfered in one of these RenderFrameHostImpl's bucket:

  • same_document_navigation_request_
  • navigation_requests_

A navigation classified as "same-document" ends up in the bucket
incompatible with error pages.
DidCommitPerNavigationMojoInterfaceNavigation expects to find the
navigation is the other bucket.

Add several regressions tests, including WPT tests.

Bug: 1018385
Change-Id: I3d92af1dd487f7b60a3e50a792716a07b074e5eb
Reviewed-on: https://chromium-review.googlesource.com/1886339
WPT-Export-Revision: 69a28ad59cd4e0163d3b612dda663335009617e5

Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]

GitHub CI Results

wpt.fyi PR Results Base Results

Ran 2 tests and 2 subtests

Firefox

OK : 1
PASS : 1
TIMEOUT: 2

Chrome

OK : 1
PASS : 1
ERROR : 1

Safari

OK : 1
PASS : 1
TIMEOUT: 2

New tests that's don't pass

/content-security-policy/frame-src/frame-src-same-document-meta.html: Firefox: TIMEOUT, Chrome: ERROR, Safari: TIMEOUT
Same-document navigations in an iframe blocked by CSP frame-src dynamically using the <meta> tag: Firefox: TIMEOUT, Chrome: MISSING, Safari: TIMEOUT

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19b0236ae31f
[wpt PR 19978] - Force error page to be classified as cross-document., a=testonly
https://hg.mozilla.org/integration/autoland/rev/526eeb5c5a5b
[wpt PR 19978] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/19b0236ae31f
https://hg.mozilla.org/mozilla-central/rev/526eeb5c5a5b

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.