1592350 - [Wayland] Firefox content window is moved when launched in normal (non-maximized) mode.

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Firefox content window is moved when launched in normal (non-maximized) mode. Affects basic and GL compositor.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

This is a regression from Bug 1587008 - but it was partially broken before it, the content was rendered moved but it was corrected after while...so fix at Bug 1587008 reveals this misbehavior.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1592350 [Wayland] Call wl_surface_commit() on parent surface when subsurface position is updated, r=jhorak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5aac68cd0f8b
[Wayland] Call wl_surface_commit() on parent surface when subsurface position is updated, r=jhorak

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/5aac68cd0f8b

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9105283 [details]
Bug 1592350 [Wayland] Call wl_surface_commit() on parent surface when subsurface position is updated, r=jhorak

Beta/Release Uplift Approval Request

• User impact if declined: Window position is incorrect on Wayland.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): linux/wayland only.
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Martin, is the regression caused by this patch in bug 1593408 a bigger problem than the one fixed here?

Comment 8

[Martin Stránský [:stransky] (ni? me)]

(In reply to Pascal Chevrel:pascalc from comment #7)

Martin, is the regression caused by this patch in bug 1593408 a bigger problem than the one fixed here?

I don't think so, looks like insufficient fix for this one for some setup (I'm unable to reproduce Bug 1593408). I'd uplift this one and I'm going to investigate/fix Bug 1593408.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9105283 [details]
Bug 1592350 [Wayland] Call wl_surface_commit() on parent surface when subsurface position is updated, r=jhorak

Wayland fix regression, we don't ship it yet officially so this is low risk but it matters for users on Wayland, especially on Fedora, uplift approved for 71 beta 8.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/34aea28bd387