Closed Bug 159241 Opened 22 years ago Closed 2 years ago

should save shortcut icon with web page

Categories

(Firefox :: File Handling, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 216907

People

(Reporter: kairo, Unassigned)

References

Details

This issue is split off bug 148797.

From Bug 148797 Comment #11 (by Adam Lock):

I might open a new bug to deal with <link> tags with a rel value specifying
shortcut/icon. This is something else we could be saving and should be easy
enough to do.

From Bug 148797 Comment #25 (by me):

Adam, just came to my mind when seeing this checkin in bonsai: what about <link
rel="icon" ...> (or "shortcut icon")?
Shouldn't that be saved with the page as well?

Enough said. Would be a nice thing to do, IMHO.
Note to self, various references to the not-very-standard-at-all definitions of
shortcut/icon rel types:

http://msdn.microsoft.com/workshop/Author/dhtml/howto/ShortcutIcon.asp
http://www.favicon.com/
bug 32087

My thoughts are any <link> containing "icon" in its rel attribute and an href
will be fixed up. It is possible that some websites might serve a bogus mimetype
for .ico, it may or may not be possible to coerce the correct behaviour by using
the 
type specified in the <link>
QA Contact: sairuh → petersen
Boris, this is one of those occasions I emailed you about where sniffing the
mime type from the stream might be useful. I discovered during testing of this
feature (which was just adding an extra few lines to the persist object) that
some sites don't send the proper mimetype with the icon. This means the persist
object screws up the file extension when it saves it.
Target Milestone: --- → Future
QA Contact: chrispetersen → file-handling
Product: Core → Firefox
Target Milestone: Future → ---
Version: Trunk → unspecified

The bug assignee didn't login in Bugzilla in the last 7 months.
:Gijs, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: adamlock → nobody
Flags: needinfo?(gijskruitbosch+bugs)
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(gijskruitbosch+bugs)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.