use setup() in more webaudio tests to wrap code that may error before tests are created
Categories
(Core :: Web Audio, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
As identified in https://bugzilla.mozilla.org/show_bug.cgi?id=1569559#c5, some web-platform tests are not wrapping setup code appropriately, which can lead to the harness assuming the test is a single page test and creating an imaginary subtest name based on the title for the file, which confuses stale expectation data cleanup.
https://phabricator.services.mozilla.com/D46685 addressed one test.
Other tests with the same pattern showed up in some of the failures in bug 1591810.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
as documented in
https://web-platform-tests.org/writing-tests/testharness-api.html#setup
On errors without setup(), the harness would assume a single page test and
report as FAIL in an imaginary subtest name based on document.title.
Wrapping in setup() leads to failures reporting as a toplevel ERROR, which
perhaps better reports the nature of the failure.
Pushed by ktomlinson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/02d15f78c542 use setup() to wrap code that may error before tests are created r=padenot
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20002 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/20002 * Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/RjVZ3zRYRpuvPXkMK5jPqw)
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
|
||
Comment 7•5 years ago
|
||
| bugherder landing | ||
Upstream PR merged by jgraham
Description
•