1592523 - Restart the browser after doing profile migration

Status: NEW

(Firefox :: Migration, task, P3)

Description

[Jan de Mooij [:jandem]]

This would break a dependency cycle that I'm working around in bug 1579367. If that bug sticks we should consider doing this.

Comment 1

[Matthew N. [:MattN]]

Is this still a problem? Could you elaborate on the details? Is this for migration from another browser or only for Firefox Refresh?

Comment 2

[Jan de Mooij [:jandem]]

(In reply to Matthew N. [:MattN] from comment #1)

Is this still a problem? Could you elaborate on the details? Is this for migration from another browser or only for Firefox Refresh?

Hi Matthew, see this comment/code for details. The initializedJSContext = true cases (both profile migrator and Refresh set it I think?) are where we initialize things like XPConnect and SpiderMonkey before we load the user prefs. That's not ideal because for certain "read only on startup" prefs it means any user pref overrides get ignored. One option to break this cycle is to restart right after doing the migration/refresh, then we can remove the initializedJSContext flag and ensure normal browser startup always loads user prefs before initializing parts of Gecko.

Comment 3

[Chris Martin [:cmartin]]

Attachment: Bug 1592523 - Restart the browser after doing profile migration

Comment 4

[Mary Higham]

Hi @ a small world cup you can reinstall the Mozilla browser.

Comment 5

[Chris Martin [:cmartin]]

I'm going to drop my patch for this bug. I've forgotten a lot about it, I'm not even sure it's relevant anymore, and I worry that I won't be able to maintain it if anything should go wrong.

mconley - Is this something that still needs to be done? I remember your team was doing work surrounding the migrator last year?