Closed Bug 1592600 Opened 4 months ago Closed 4 months ago

A new preferences tab will be opened if Firefox preferences is actioned from Addons Manager

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla72
Tracking Status
firefox-esr68 --- wontfix
firefox70 --- wontfix
firefox71 --- verified
firefox72 --- verified

People

(Reporter: csasca, Assigned: Gijs)

Details

(Keywords: regression, regressionwindow-wanted)

Attachments

(1 file)

Affected versions

  • Firefox 72.0a1
  • Firefox 71.0b5
  • Firefox 68.2.0esr

Affected platforms

  • macOS 10.15
  • Ubuntu 18.04 (x64)
  • Windows 10 (x64)

Steps to reproduce

  1. Launch Firefox
  2. Access Preferences
  3. Select Search
  4. Click on Extensions & Themes from the lower left page
  5. Click on Firefox Preferences from the lower left page
  6. Following the same steps will open a new preferences tab everytime

Expected result

  • Preferences tab is recognized and switched to everytime Firefox Preferences is clicked.

Actual result

  • If another section, other than General is selected in preferences, a new preferences tab will be opened everytime Firefox preferences is clicked.

Regression range

  • I will look into a regression.

Additional notes

  • The actual issue can be seen in this attachment.
  • 60.9.0esr is not affected, as Firefox Preferences is not present in Addons Manager.
Has Regression Range: --- → no
Has STR: --- → yes

https://searchfox.org/mozilla-central/rev/1fe0cf575841dbf3b7e159e88ba03260cd1354c0/toolkit/mozapps/extensions/content/extensions.js#145-153 should pass ignoreFragment: true in the options to switchToTabHavingURI.

Also, it shouldn't activate for right-clicks.

Component: Preferences → Add-ons Manager
Product: Firefox → Toolkit
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/da8fb04a3691
fix prefs link in about:addons to ignore hashes/fragments as well as right clicks, r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Hello,

Verified the fix on the latest Nightly (72.0a1/20191103213857) under Windows 10 Pro 64-bit, MacOS Catalina 10.15 and Ubuntu 18.04.3 LTS.

Clicking on the “Nightly Options” button from the Addons Manager page or the “Extensions & Themes” button from the Nightly Options page will switch between the mentioned pages, keeping focus on the tab from which the action was performed from. Also, as mentioned in Comment 1, right clicking the buttons does not work. The fix is confirmed.

Status: RESOLVED → VERIFIED

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Gijs, is that something we could uplift to beta or do you think there is some risk? Thanks

Flags: needinfo?(gijskruitbosch+bugs)

Comment on attachment 9105566 [details]
Bug 1592600 - fix prefs link in about:addons to ignore hashes/fragments as well as right clicks, r?mstriemer

Beta/Release Uplift Approval Request

  • User impact if declined: Broken link behaviour in about:addons / about:preferences
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce: Verification not really urgently required, but if you wanna do it, see comment #0
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This just fixes with what parameters about:addons opens about:preferences, and also takes the opportunity to avoid having right-clicks on either link do something like opening the item. It's a small JS-only patch, specific to the links being fixed.
  • String changes made/needed: Nope
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #9105566 - Flags: approval-mozilla-beta?

Comment on attachment 9105566 [details]
Bug 1592600 - fix prefs link in about:addons to ignore hashes/fragments as well as right clicks, r?mstriemer

Low risk, verified in Nightly, uplift approved for 71 beta 12, thanks.

Attachment #9105566 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Hello,

Verified the fix on the latest Beta (71.0b12/20191121155457) under Windows 10 Pro 64-bit and MacOS Catalina 10.15.

Clicking on the “Firefox Options” button from the Addons Manager page or the “Extensions & Themes” button from the Firefox Options page will switch between the mentioned pages, keeping focus on the tab from which the action was performed from. Also, right clicking the buttons does not work. The fix is confirmed.

You need to log in before you can comment on or make changes to this bug.