[wpt-sync] Sync PR 19994 - Fix allow attribute timing issue on browser side
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 19994 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/19994
Details from upstream follow.
Charlie Hu <chenleihu@google.com> wrote:
Fix allow attribute timing issue on browser side
The issue of allow attribute timing originates from bug crbug.com/972089.
The initial fix to that bug only deals with feature policy replication
problem on renderer side.This CL adds a wpt test that targets a feature(camera) that is tested on
browser side. A test on similar issue with sandbox attribute is added
as well, but is currently failing. The sandbox attribute part will be fixed
in future CLs.On browser-side:
Frame policy value is captured at RenderFrameHostImpl::BeginNavigation,
and travel through the whole navigation process in
NavigationRequest::common_params. Finally it will reach
NavigatorImpl::DidNavigate which is called by
RenderFrameHostImpl::DidCommitNavigationInternal.NavigatorImpl will then use the value captured from the beginning of navigation
in common_params to set the active frame policy instead of using currently
pending frame policy, which could be further modified at the commit of navigation.Bug: 1012786
Change-Id: Ib944ee204ca82e1ede6052ca58187fe97f0aab00Reviewed-on: https://chromium-review.googlesource.com/1852905
WPT-Export-Revision: e3c42ca4eecc7af4080e87cd6bf09b102c8fba85
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
PR 19994 applied with additional changes from upstream: 1da988941a8c83f13aa71447a188335f5cc35ab0
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=53729b9d8f65d6bed19144608860057e22488800
|
|
Assignee | |
Comment 3•4 years ago
|
||
Test result changes from PR not available.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Test result changes from PR not available.
|
|
Assignee | |
Comment 5•4 years ago
|
||
CI Results
Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 3 tests and 1 subtests
Status Summary
Firefox
OK : 3
PASS: 1
FAIL: 3
Chrome
OK : 3
PASS: 1
FAIL: 3
Safari
OK : 3
PASS: 1
FAIL: 3
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
/feature-policy/feature-policy-frame-policy-timing.https.sub.html
allow attr timing test diff origin: FAIL (Chrome: FAIL, Safari: FAIL)
allow attr timing test same origin: FAIL (Chrome: FAIL, Safari: FAIL)
/html/browsers/sandboxing/sandbox-navigation-timing.tentative.html
setting sandbox attribute should not affect current document in iframe: FAIL (Chrome: FAIL, Safari: FAIL)
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e374e85cec30
https://hg.mozilla.org/mozilla-central/rev/82bf95ee148e
Description
•