Closed Bug 1592604 Opened 5 years ago Closed 5 years ago

Highlighter <> badge <> checkbox state can get out of sync

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox72 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 72
Tracking Flags:
Tracking Status
firefox72 --- fixed

People

(Reporter: mbalfanz, Assigned: rcaliman)

Details

Attachments

(2 files)

out-of-sync.mp4
1.98 MB, video/mp4
Details
Bug 1592604 - Ensure flexbox highlighter events don't influence grid badges in markup view. r=gl
47 bytes, text/x-phabricator-request
Details | Review
Attached video out-of-sync.mp4 —

STR:

  • Visit cnn.com and scroll to the very bottom
  • open devtools and enable the grid highlighter for the footer
  • enable the flex highlighter for the footer

AR:

  • grid badge gets disabled, even though the highlighter is still shown. States of highlighter vs. badge vs. checkbox get out of sync

ER:

  • badges & checkboxes should show the actual state of the highlighter
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Priority: -- → P3

When creating grid and display badges in the markup view, ensure they listen only to their corresponding highlighter events.

Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cbdf479b1cdc
Ensure flexbox highlighter events don't influence grid badges in markup view. r=gl

https://hg.mozilla.org/mozilla-central/rev/cbdf479b1cdc

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: