Closed Bug 1592667 Opened 5 years ago Closed 3 years ago

tabs are restored in wrong windows from session restore

Categories

(Firefox :: Session Restore, defect, P3)

70 Branch
x86_64
Linux
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- fix-optional

People

(Reporter: hpj, Unassigned, NeedInfo)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Session manager of Firefox 70 remembers the window position (aka geometry) on multiple desktops correctly (note: no multi monitor setup), but it mixes the content (tabs from one window appear in another), which renders the result of session restore useless, given the window location is a significant part of the session setup (which will be true for any complex setup, here it's about 20 windows with different amounts of tabs, distributed on some of 12 desktops).

This issue is part of a bigger problem, that is recorded in Bug 372650. Adam Gashlin suggested to create a new bug. It's one of the most disrupting long time issues for Linux based power users since 13 years now.

Steps to reproduce:

  • install a decent Linux DE (I'm using openSUSE Tumbleweed with Plasma DE)
  • open a few dolphin, kate and firefox windows
  • log out and log in
  • the dolphin and kate windows restore just fine every time, even FF might do for a while
  • repeat the latter two steps

After a while, the result deviates from the expected order (content of one window appears in another).

From a user perspective, this issue is related to another issue: window geometry (location and desktop) doesn't match the state of the former session. Both bad behaviors changed during the latest cycles: 68.* got it working correctly for a short time. With 69., the content was restored correctly most of the times, but geometry failed sometimes (without a visible pattern). With 70., geometry seems fine again, but content is mixed up reproducible.

In order to deal with this behavior, I've created a ff-backup-session-recovery.sh script (attached), that is able to store, list and restore sessions. It's triggered from crontab, during log off, and manually.

Here's my usual procedure to log off/reboot:

# store session manually before FF exit, just to have another restore point
$ ff-backup-session-recovery.sh
# log off/reboot
# after login, session is most prabably fscked up again, kill FF
# select and restore session from backup
$ ff-backup-session-recovery.sh list
[...]
-rw------- 1 hp lisa 1413605 29. Okt 15:19 recovery.jsonlz4.20191030-044501
-rw------- 1 hp lisa 1406568 30. Okt 17:10 recovery.jsonlz4.20191030-171110
-rw------- 1 hp lisa 1406564 30. Okt 17:11 recovery.jsonlz4
[...]
$ ff-backup-session-recovery.sh restore recovery.jsonlz4.20191030-171110
# run Firefox 70 on first desktop, will open *all* windows on this desktop
# distribute windows to the desktops, they belong to
# switch to each desktop with FF windows, and "shutter" them as usual
# work
See Also: → 372650

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mdeboer)

I know it's been a while, but can I take a look at that sessionstore.jsonlz4 file parhaps to see if I can reproduce the problem?
Did you try to restore using this file in a fresh profile?

P3 due to no solid STR.

Severity: normal → S2
Flags: needinfo?(mdeboer) → needinfo?(hpj)
Priority: -- → P3

S1 or S2 bugs needs an assignee - could you find someone for this bug?

Flags: needinfo?(mdeboer)

Marking this as S3 as it appears that S2 (Serious) Major functionality/product severely impaired - is not the correct severity here. Please update if this is incorrectly categorized.

Severity: S2 → S3

This very issue is fixed for good in later Firefox versions. Sorry to have missed the request.

Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(hpj)
Resolution: --- → WORKSFORME

(In reply to Hans-Peter Jansen from comment #7)

This very issue is fixed for good in later Firefox versions. Sorry to have missed the request.

On Firefox 84.0.2 it's not fixed.
Terminate the browser via task manager then start it again: every window gets restored in the current virtual desktop instead of the correct one.
Am I missing something?

(In reply to LoneDev from comment #8)

(In reply to Hans-Peter Jansen from comment #7)

This very issue is fixed for good in later Firefox versions. Sorry to have missed the request.

On Firefox 84.0.2 it's not fixed.
Terminate the browser via task manager then start it again: every window gets restored in the current virtual desktop instead of the correct one.
Am I missing something?

Wops, sorry, wrong issue.
I thought it was this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1643936

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: