1592681 - android-hw raptor tasks do not exit with TBPL_RETRY after hitting ADBTimeoutError

Status: RESOLVED FIXED

(Testing :: General, defect, P1)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

As noticed in bug 1500266.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

This is making sense: The raptor mozharness script, raptor_script.py, uses RaptorOutputParser, which makes no allowance for the retry regex or retry error codes.

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: Bug 1592681 - Update raptor mozharness output parser to respect retry regex; r=

When certain strings are logged - "ADBTimeoutError", "INFRA-ERROR", etc - mozharness tasks
usually retry: The task exits with TBPL_RETRY (4), is reported as "blue" in treeherder, and
a new task is automatically started. This patch implements missing retry logic for raptor
tasks, copying the logic from
https://searchfox.org/mozilla-central/rev/59de675101da711520c0bb6e34a1ea2372e7ddbb/testing/mozharness/mozharness/mozilla/testing/unittest.py#169-174

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92675fb8d829
Update raptor mozharness output parser to respect retry regex; r=perftest-reviewers,rwood

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/92675fb8d829

Comment 5

[Geoff Brown [:gbrown] (pto Apr 11-18)]

We are starting to see retries on ADBTimeoutError:

https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=274533567&searchStr=android%2Craptor&revision=c85ae1289d33e348bdda56d6ae3f61a987f784d7

Hurrah!